Initial work to remove the notion of all extension message payloads as strings.

chrome/browser/extensions/extension_event_router.h

Index: chrome/browser/extensions/extension_event_router.h
diff --git a/chrome/browser/extensions/extension_event_router.h b/chrome/browser/extensions/extension_event_router.h
index bbb3e22d4858e9803d1621496229333ff83acc4a..ef9adfcb833fcc1e7ca2411cd99c38afd589c4ea 100644
--- a/chrome/browser/extensions/extension_event_router.h
+++ b/chrome/browser/extensions/extension_event_router.h
@@ -13,6 +13,7 @@
 #include "base/compiler_specific.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/ref_counted.h"
+#include "base/values.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ipc/ipc_sender.h"
@@ -45,6 +46,12 @@ class ExtensionEventRouter : public content::NotificationObserver {
   static void DispatchEvent(IPC::Sender* ipc_sender,
                             const std::string& extension_id,
                             const std::string& event_name,
+                            const base::Value& event_args,
+                            const GURL& event_url,
+                            UserGestureState user_gesture);
+  static void DispatchEvent(IPC::Sender* ipc_sender,

[asargent_no_longer_on_chrome, 2012/06/18 16:25:30]

Can you add a comment here saying that this is deprecated and to prefer using
the above version that takes a Value instead of a std::string with JSON?

[Garret Kelly, 2012/06/18 18:15:01]

Done.

+                            const std::string& extension_id,
+                            const std::string& event_name,
                             const std::string& event_args,
                             const GURL& event_url,
                             UserGestureState user_gesture);
@@ -98,6 +105,12 @@ class ExtensionEventRouter : public content::NotificationObserver {
       const std::string& event_args,
       Profile* restrict_to_profile,
       const GURL& event_url);
+  virtual void DispatchEventToExtension(

[asargent_no_longer_on_chrome, 2012/06/18 16:25:30]

add same comment here

[Garret Kelly, 2012/06/18 18:15:01]

Done.

+      const std::string& extension_id,
+      const std::string& event_name,
+      const base::Value& event_args,
+      Profile* restrict_to_profile,
+      const GURL& event_url);
 
   // Dispatch an event to particular extension. Also include an
   // explicit user gesture indicator.
@@ -168,7 +181,7 @@ class ExtensionEventRouter : public content::NotificationObserver {
       Profile* profile,
       const extensions::Extension* extension,
       const linked_ptr<ExtensionEvent>& event,
-      const std::string** event_args);
+      const base::Value** event_args);
 
   // Ensures that all lazy background pages that are interested in the given
   // event are loaded, and queues the event if the page is not ready yet.