chrome/browser/extensions/extension_browser_event_router.cc - Issue 10565017: Parse the script_badge manifest section.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_event_router.cc

Issue 10565017: Parse the script_badge manifest section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix more review comments, and make script_badge_ non-mutable Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browser_event_router.cc

diff --git a/chrome/browser/extensions/extension_browser_event_router.cc b/chrome/browser/extensions/extension_browser_event_router.cc

index bd7b91183fb730b2a26d8d9cff42ea465f0a042a..b578d76d34490baa80ab050fb391d8585e43787a 100644

--- a/chrome/browser/extensions/extension_browser_event_router.cc

+++ b/chrome/browser/extensions/extension_browser_event_router.cc

@@ -689,6 +689,9 @@ void ExtensionBrowserEventRouter::ExtensionActionExecuted(

case ExtensionAction::TYPE_PAGE:

event_name = "pageAction.onClicked";

break;

+ case ExtensionAction::TYPE_SCRIPT_BADGE:

+ event_name = "scriptBadge.onClicked";

+ break;

}

if (event_name) {