Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc

Issue 10565017: Parse the script_badge manifest section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix more review comments, and make script_badge_ non-mutable Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "chrome/common/extensions/extension_action.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/extension_switch_utils.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "third_party/skia/include/core/SkBitmap.h"
13
14 namespace errors = extension_manifest_errors;
15 namespace switch_utils = extensions::switch_utils;
16 using extensions::Extension;
17
18 TEST_F(ExtensionManifestTest, ScriptBadgeBasic) {
19 switch_utils::ScopedSetScriptBadgeForTest _(switch_utils::ENABLED);
not at google - send to devlin 2012/06/19 00:27:32 the point of those comments was to get rid of need
20 scoped_refptr<Extension> extension(
21 LoadAndExpectSuccess("script_badge_basic.json"));
22 ASSERT_TRUE(extension.get());
23 ASSERT_TRUE(extension->script_badge());
24 EXPECT_THAT(extension->install_warnings(),
25 testing::ElementsAre(/*empty*/));
26
27 EXPECT_EQ("Hello World", extension->script_badge()->GetTitle(
28 ExtensionAction::kDefaultTabId));
29 EXPECT_TRUE(extension->script_badge()->HasPopup(
30 ExtensionAction::kDefaultTabId));
31 EXPECT_TRUE(extension->script_badge()->GetIcon(
32 ExtensionAction::kDefaultTabId).isNull());
33 EXPECT_EQ("icon16.png", extension->script_badge()->default_icon_path());
34 }
35
36 TEST_F(ExtensionManifestTest, ScriptBadgeWarnsWithoutActionBox) {
37 switch_utils::ScopedSetScriptBadgeForTest _(switch_utils::DISABLED);
38 scoped_refptr<Extension> extension(
39 LoadAndExpectSuccess("script_badge_basic.json"));
40 ASSERT_TRUE(extension.get());
41 ASSERT_TRUE(extension->script_badge());
42 EXPECT_THAT(extension->install_warnings(),
43 testing::ElementsAre(
44 Extension::InstallWarning(
45 Extension::InstallWarning::FORMAT_TEXT,
46 errors::kScriptBadgeRequiresFlag)));
47
48 EXPECT_EQ("my extension", extension->script_badge()->GetTitle(
49 ExtensionAction::kDefaultTabId));
50 }
51
52 TEST_F(ExtensionManifestTest, ScriptBadgeExplicitIconsIgnored) {
53 switch_utils::ScopedSetScriptBadgeForTest _(switch_utils::ENABLED);
54
55 scoped_refptr<Extension> extension(
56 LoadAndExpectSuccess("script_badge_icons_ignored.json"));
57 ASSERT_TRUE(extension.get());
58 ASSERT_TRUE(extension->script_badge());
59
60 EXPECT_THAT(extension->install_warnings(),
61 testing::ElementsAre(
62 Extension::InstallWarning(
63 Extension::InstallWarning::FORMAT_TEXT,
64 errors::kScriptBadgeIconIgnored)));
65 EXPECT_TRUE(extension->script_badge()->GetIcon(
66 ExtensionAction::kDefaultTabId).isNull());
67 EXPECT_EQ("icon16.png", extension->script_badge()->default_icon_path());
68 }
69
70 TEST_F(ExtensionManifestTest, ScriptBadgeIconFallsBackToPuzzlePiece) {
71 switch_utils::ScopedSetScriptBadgeForTest _(switch_utils::ENABLED);
72
73 scoped_refptr<Extension> extension(
74 LoadAndExpectSuccess("script_badge_only_use_icon16.json"));
75 ASSERT_TRUE(extension.get());
76 ASSERT_TRUE(extension->script_badge());
77 EXPECT_THAT(extension->install_warnings(),
78 testing::ElementsAre(/*empty*/));
79
80 EXPECT_EQ("", extension->script_badge()->default_icon_path())
81 << "Should not fall back to the 64px icon.";
82 EXPECT_FALSE(extension->script_badge()->GetIcon(
83 ExtensionAction::kDefaultTabId).isNull())
84 << "Should set the puzzle piece as the default, but there's no way "
85 << "to assert in a unittest what the image looks like.";
86 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698