Switch template_utils_unittest to using COMPILE_ASSERT.

base/template_util_unittest.cc

Index: base/template_util_unittest.cc
diff --git a/base/template_util_unittest.cc b/base/template_util_unittest.cc
index b330a013f6f7ccc222a2be74c320a2559c05cec0..cc166fc17ecb599d642a6ed91ca6175955578d54 100644
--- a/base/template_util_unittest.cc
+++ b/base/template_util_unittest.cc
@@ -3,6 +3,8 @@
 // found in the LICENSE file.
 
 #include "base/template_util.h"
+
+#include "base/basictypes.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
@@ -15,71 +17,71 @@ enum AnEnum {};
 class Parent {};
 class Child : public Parent {};
 
-TEST(TemplateUtilTest, IsPointer) {
-  EXPECT_FALSE(is_pointer<int>::value);
-  EXPECT_FALSE(is_pointer<int&>::value);
-  EXPECT_TRUE(is_pointer<int*>::value);
-  EXPECT_TRUE(is_pointer<const int*>::value);
-}
-
-TEST(TemplateUtilTest, IsArray) {
-  EXPECT_FALSE(is_array<int>::value);
-  EXPECT_FALSE(is_array<int*>::value);
-  EXPECT_FALSE(is_array<int(*)[3]>::value);
-  EXPECT_TRUE(is_array<int[]>::value);
-  EXPECT_TRUE(is_array<const int[]>::value);
-  EXPECT_TRUE(is_array<int[3]>::value);
-}
-
-TEST(TemplateUtilTest, IsNonConstReference) {
-  EXPECT_FALSE(is_non_const_reference<int>::value);
-  EXPECT_FALSE(is_non_const_reference<const int&>::value);
-  EXPECT_TRUE(is_non_const_reference<int&>::value);
-}
-
-TEST(TemplateUtilTest, IsConvertible) {
-  // Extra parens needed to make EXPECT_*'s parsing happy. Otherwise,
-  // it sees the equivalent of
-  //
-  //  EXPECT_TRUE( (is_convertible < Child), (Parent > ::value));
-  //
-  // Silly C++.
-  EXPECT_TRUE( (is_convertible<Child, Parent>::value) );
-  EXPECT_FALSE( (is_convertible<Parent, Child>::value) );
-  EXPECT_FALSE( (is_convertible<Parent, AStruct>::value) );
-
-  EXPECT_TRUE( (is_convertible<int, double>::value) );
-  EXPECT_TRUE( (is_convertible<int*, void*>::value) );
-  EXPECT_FALSE( (is_convertible<void*, int*>::value) );
-
-  // Array types are an easy corner case.  Make sure to test that
-  // it does indeed compile.
-  EXPECT_FALSE( (is_convertible<int[10], double>::value) );
-  EXPECT_FALSE( (is_convertible<double, int[10]>::value) );
-  EXPECT_TRUE( (is_convertible<int[10], int*>::value) );
-}
-
-TEST(TemplateUtilTest, IsSame) {
-  EXPECT_FALSE( (is_same<Child, Parent>::value) );
-  EXPECT_FALSE( (is_same<Parent, Child>::value) );
-  EXPECT_TRUE( (is_same<Parent, Parent>::value) );
-
-  EXPECT_TRUE( (is_same<int*, int*>::value) );
-  EXPECT_TRUE( (is_same<int, int>::value) );
-  EXPECT_TRUE( (is_same<void, void>::value) );
-  EXPECT_FALSE( (is_same<int, double>::value) );
-}
-
-TEST(TemplateUtilTest, IsClass) {
-  EXPECT_TRUE(is_class<AStruct>::value);
-  EXPECT_TRUE(is_class<AClass>::value);
-
-  EXPECT_FALSE(is_class<AnEnum>::value);
-  EXPECT_FALSE(is_class<int>::value);
-  EXPECT_FALSE(is_class<char*>::value);
-  EXPECT_FALSE(is_class<int&>::value);
-  EXPECT_FALSE(is_class<char[3]>::value);
-}
+// is_pointer<Type>
+

[Jeffrey Yasskin, 2012/06/18 21:36:00]

Nit: I would skip the blank lines between the header comments and the
COMPILE_ASSERTs implementing them.

+COMPILE_ASSERT(!is_pointer<int>::value, IsPointer);
+COMPILE_ASSERT(!is_pointer<int&>::value, IsPointer);
+COMPILE_ASSERT(is_pointer<int*>::value, IsPointer);
+COMPILE_ASSERT(is_pointer<const int*>::value, IsPointer);
+
+// is_array<Type>
+
+COMPILE_ASSERT(!is_array<int>::value, IsArray);
+COMPILE_ASSERT(!is_array<int*>::value, IsArray);
+COMPILE_ASSERT(!is_array<int(*)[3]>::value, IsArray);
+COMPILE_ASSERT(is_array<int[]>::value, IsArray);
+COMPILE_ASSERT(is_array<const int[]>::value, IsArray);
+COMPILE_ASSERT(is_array<int[3]>::value, IsArray);
+
+// is_non_const_reference<Type>
+
+COMPILE_ASSERT(!is_non_const_reference<int>::value, IsNonConstReference);
+COMPILE_ASSERT(!is_non_const_reference<const int&>::value, IsNonConstReference);
+COMPILE_ASSERT(is_non_const_reference<int&>::value, IsNonConstReference);
+
+// is_convertible<From, To>
+
+// Extra parens needed to make preprocessor macro parsing happy. Otherwise,
+// it sees the equivalent of:
+//
+//     (is_convertible < Child), (Parent > ::value)
+//
+// Silly C++.
+
+COMPILE_ASSERT( (is_convertible<Child, Parent>::value), IsConvertible);
+COMPILE_ASSERT(!(is_convertible<Parent, Child>::value), IsConvertible);
+COMPILE_ASSERT(!(is_convertible<Parent, AStruct>::value), IsConvertible);
+COMPILE_ASSERT( (is_convertible<int, double>::value), IsConvertible);
+COMPILE_ASSERT( (is_convertible<int*, void*>::value), IsConvertible);
+COMPILE_ASSERT(!(is_convertible<void*, int*>::value), IsConvertible);
+
+// Array types are an easy corner case.  Make sure to test that
+// it does indeed compile.
+COMPILE_ASSERT(!(is_convertible<int[10], double>::value), IsConvertible);
+COMPILE_ASSERT(!(is_convertible<double, int[10]>::value), IsConvertible);
+COMPILE_ASSERT( (is_convertible<int[10], int*>::value), IsConvertible);
+
+// is_same<Type1, Type2>
+
+COMPILE_ASSERT(!(is_same<Child, Parent>::value), IsSame);
+COMPILE_ASSERT(!(is_same<Parent, Child>::value), IsSame);
+COMPILE_ASSERT( (is_same<Parent, Parent>::value), IsSame);
+COMPILE_ASSERT( (is_same<int*, int*>::value), IsSame);
+COMPILE_ASSERT( (is_same<int, int>::value), IsSame);
+COMPILE_ASSERT( (is_same<void, void>::value), IsSame);
+COMPILE_ASSERT(!(is_same<int, double>::value), IsSame);
+
+
+// is_class<Type>
+
+COMPILE_ASSERT(is_class<AStruct>::value, IsClass);
+COMPILE_ASSERT(is_class<AClass>::value, IsClass);
+COMPILE_ASSERT(!is_class<AnEnum>::value, IsClass);
+COMPILE_ASSERT(!is_class<int>::value, IsClass);
+COMPILE_ASSERT(!is_class<char*>::value, IsClass);
+COMPILE_ASSERT(!is_class<int&>::value, IsClass);
+COMPILE_ASSERT(!is_class<char[3]>::value, IsClass);
+
 
 }  // namespace
 }  // namespace base