Added files for audio readers.

remoting/protocol/audio_reader.h

Index: remoting/protocol/audio_reader.h
diff --git a/remoting/protocol/audio_reader.h b/remoting/protocol/audio_reader.h
new file mode 100644
index 0000000000000000000000000000000000000000..2d708db939f1f89b4abcb4ea389629a6cd95f1f4
--- /dev/null
+++ b/remoting/protocol/audio_reader.h
@@ -0,0 +1,67 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_AUDIO_READER_H_
+#define REMOTING_PROTOCOL_AUDIO_READER_H_
+
+#include "base/callback.h"
+#include "base/compiler_specific.h"
+#include "remoting/proto/audio.pb.h"
+#include "remoting/protocol/audio_stub.h"
+#include "remoting/protocol/message_reader.h"
+
+namespace net {
+class StreamSocket;
+}  // namespace net
+
+namespace remoting {
+namespace protocol {
+
+class Session;
+class SessionConfig;
+
+class AudioReader {
+ public:
+  // The callback is called when initialization is finished. The
+  // parameter is set to true on success.
+  typedef base::Callback<void(bool)> InitializedCallback;
+
+  virtual ~AudioReader();
+
+  static scoped_ptr<AudioReader> Create(const SessionConfig& config);

[Wez, 2012/06/15 20:40:54]

Document this Create() function.

+
+  // Initializies the reader.

[Wez, 2012/06/15 20:40:54]

typo: Initializes

[Wez, 2012/06/15 20:40:54]

What does it mean to "initialize the reader"? What does initialization actually
do? Who owns |session| and |audio_stub|, and what guarantees do they need to
provide about the object's lifetimes?

+  void Init(Session* session,
+            AudioStub* audio_stub,
+            const InitializedCallback& callback);
+  bool is_connected();

[Wez, 2012/06/15 20:40:54]

nit: const

+
+ private:
+  explicit AudioReader(AudioPacket::Encoding encoding);
+
+  void OnChannelReady(scoped_ptr<net::StreamSocket> socket);
+  void OnNewData(scoped_ptr<AudioPacket> packet,

[Wez, 2012/06/15 20:40:54]

nit: OnNewData -> OnAudioData or OnAudioPacket

+                 const base::Closure& done_task);
+
+  Session* session_;

[Wez, 2012/06/15 20:40:54]

Why not keep |session_|, |audio_stub_| and |initialized_callback_| together,
since they are the parameters the caller passed in to Init?

+
+  InitializedCallback initialized_callback_;
+
+  AudioPacket::Encoding encoding_;
+
+  // TODO(sergeyu): Remove |channel_| and let |reader_| own it.
+  scoped_ptr<net::StreamSocket> channel_;
+
+  ProtobufMessageReader<AudioPacket> reader_;
+
+  // The stub that processes all received packets.
+  AudioStub* audio_stub_;
+
+  DISALLOW_COPY_AND_ASSIGN(AudioReader);
+};
+
+}  // namespace protocol
+}  // namespace remoting
+
+#endif  // REMOTING_PROTOCOL_AUDIO_READER_H_