Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: chrome/browser/extensions/api/usb/usb_device_resource.cc

Issue 10561021: Change the USB extension API to use ArrayBuffers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/usb/usb_device_resource.cc
diff --git a/chrome/browser/extensions/api/usb/usb_device_resource.cc b/chrome/browser/extensions/api/usb/usb_device_resource.cc
index f2046d410a2072f03dc2aaac88dfe25423cf4af6..f90ef5a9589d88cb6d44cb76c181cfa1b83ea259 100644
--- a/chrome/browser/extensions/api/usb/usb_device_resource.cc
+++ b/chrome/browser/extensions/api/usb/usb_device_resource.cc
@@ -94,7 +94,7 @@ static bool GetTransferSize(const T& input, size_t* output) {
}
} else if (input.direction == kDirectionOut) {
if (input.data.get()) {
- *output = input.data->size();
+ *output = input.data->GetSize();
return true;
}
}
@@ -113,10 +113,7 @@ static scoped_refptr<net::IOBuffer> CreateBufferForTransfer(const T& input) {
return buffer;
}
- const vector<int>& input_buffer = *input.data.get();
- for (size_t i = 0; i < size; ++i) {
- buffer->data()[i] = input_buffer[i];
- }
+ memcpy(buffer->data(), input.data->GetBuffer(), size);
return buffer;
}
@@ -209,11 +206,8 @@ void UsbDeviceResource::TransferComplete(net::IOBuffer* buffer,
const size_t length,
int success) {
if (buffer) {
- base::ListValue *const response_buffer = new base::ListValue();
- for (size_t i = 0; i < length; ++i) {
- const uint8_t value = buffer->data()[i] & 0xFF;
- response_buffer->Append(base::Value::CreateIntegerValue(value));
- }
+ base::BinaryValue* const response_buffer =
+ base::BinaryValue::CreateWithCopiedBuffer(buffer->data(), length);
event_notifier()->OnTransferComplete(success, response_buffer);
}
}

Powered by Google App Engine
This is Rietveld 408576698