Issue 10561021: Change the USB extension API to use ArrayBuffers.

Issue 10561021: Change the USB extension API to use ArrayBuffers. (Closed)

Created:
8 years, 6 months ago by Garret Kelly

Modified:
8 years, 6 months ago

Reviewers:
miket_OOO, bryeung, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change the USB extension API to use ArrayBuffers. BUG=130181 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142827

Patch Set 2 : Review changes + rebase #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -21 lines)			Patch
M	chrome/browser/extensions/api/api_resource_event_notifier.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/api_resource_event_notifier.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_device_resource.cc	View		3 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/common/extensions/api/experimental_usb.idl	View	1	5 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

miket_OOO

Just one comment. LGTM. http://codereview.chromium.org/10561021/diff/1/chrome/common/extensions/api/experimental_usb.idl File chrome/common/extensions/api/experimental_usb.idl (right): http://codereview.chromium.org/10561021/diff/1/chrome/common/extensions/api/experimental_usb.idl#newcode7 chrome/common/extensions/api/experimental_usb.idl:7: // temporary and will be ...

8 years, 6 months ago (2012-06-18 16:30:14 UTC) #4

Garret Kelly

To save myself another change peeling session I'll just do a rebase on this once ...

8 years, 6 months ago (2012-06-18 18:21:26 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10561021/5001

8 years, 6 months ago (2012-06-18 20:07:09 UTC) #6

Change committed as 142827

Expand Messages | Collapse Messages