Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 10561003: Implementaion for showing recently closed tabs list on right clicking new tab button. (Closed)

Created:
8 years, 6 months ago by SanjoyPal
Modified:
8 years, 5 months ago
Reviewers:
Glen Murphy, benjhayden, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Implementaion for showing recently closed tabs list on right clicking new tab button. BUG=98297 TEST=Manual.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -1 line) Patch
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 7 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 4 chunks +24 lines, -0 lines 0 comments Download
A chrome/browser/ui/tabs/recently_closed_tabs_menu_model.h View 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/browser/ui/tabs/recently_closed_tabs_menu_model.cc View 1 chunk +197 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
SanjoyPal
Hi Scott, Glen, I was working on bug for recently closed tab (crbug.com/102607) and came ...
8 years, 6 months ago (2012-06-15 12:47:21 UTC) #1
sky
Glen will have to answer whether he wants right click to do this. -Scott On ...
8 years, 6 months ago (2012-06-15 19:50:43 UTC) #2
SanjoyPal
ping.
8 years, 5 months ago (2012-07-04 06:11:57 UTC) #3
Peter Kasting
8 years, 5 months ago (2012-07-04 06:24:09 UTC) #4
I closed the bug because the main idea in it -- reopening previously closed tabs
on middle-clicking the new tab button (or tab strip) -- is something we've
explicitly WontFixed before.

Given that, adding a list of recently closed tabs to the new tab context menu
doesn't make a lot of sense either.  I would close this.

Powered by Google App Engine
This is Rietveld 408576698