Omnibox M5 work, part 1: Security changes...

chrome/browser/ssl/ssl_manager.cc

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_manager.h"
 
 #include "app/l10n_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/load_from_memory_cache_details.h"
 #include "chrome/browser/net/url_request_tracking.h"
@@ skipping 252 matching lines @@
   }
 
   Pickle pickle(state.data(), static_cast<int>(state.size()));
   void * iter = NULL;
   return pickle.ReadInt(&iter, cert_id) &&
          pickle.ReadInt(&iter, cert_status) &&
          pickle.ReadInt(&iter, security_bits);
 }
 
 // static
-bool SSLManager::GetEVCertNames(const net::X509Certificate& cert,
-                                std::wstring* short_name,
-                                std::wstring* ca_name) {
-  DCHECK(short_name || ca_name);
-
+std::wstring SSLManager::GetEVCertName(const net::X509Certificate& cert) {
   // EV are required to have an organization name and country.
   if (cert.subject().organization_names.empty() ||
       cert.subject().country_name.empty()) {
     NOTREACHED();
-    return false;
+    return std::wstring();
   }
 
-  if (short_name) {
-    *short_name = l10n_util::GetStringF(
-        IDS_SECURE_CONNECTION_EV,
-        UTF8ToWide(cert.subject().organization_names[0]),
-        UTF8ToWide(cert.subject().country_name));
-  }
-
-  if (ca_name) {
-    // TODO(wtc): should we show the root CA's name instead?
-    *ca_name = l10n_util::GetStringF(
-        IDS_SECURE_CONNECTION_EV_CA,
-        UTF8ToWide(cert.issuer().organization_names[0]));
-  }
-  return true;
+  return l10n_util::GetStringF(IDS_SECURE_CONNECTION_EV,
+                               UTF8ToWide(cert.subject().organization_names[0]),
+                               UTF8ToWide(cert.subject().country_name));
 }