Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1774)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/sessions/sync_session_unittest.cc

Issue 10559104: sync: Process 'control' data separately (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename, cleanup, fix tests Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/sync_session.cc ('k') | sync/sync.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/sync_session_unittest.cc
diff --git a/sync/sessions/sync_session_unittest.cc b/sync/sessions/sync_session_unittest.cc
index f1d80315b641a0010bbc554527a6d6a66458605f..0787b80695b67da37234d34bae6cdf7c02692a6f 100644
--- a/sync/sessions/sync_session_unittest.cc
+++ b/sync/sessions/sync_session_unittest.cc
@@ -56,11 +56,14 @@ class SyncSessionTest : public testing::Test,
routes_[syncable::AUTOFILL] = GROUP_DB;
scoped_refptr<ModelSafeWorker> passive_worker(
new FakeModelWorker(GROUP_PASSIVE));
+ scoped_refptr<ModelSafeWorker> control_worker(
+ new FakeModelWorker(GROUP_CONTROL));
scoped_refptr<ModelSafeWorker> ui_worker(
new FakeModelWorker(GROUP_UI));
scoped_refptr<ModelSafeWorker> db_worker(
new FakeModelWorker(GROUP_DB));
workers_.clear();
+ workers_.push_back(control_worker);
workers_.push_back(passive_worker);
workers_.push_back(ui_worker);
workers_.push_back(db_worker);
@@ -143,6 +146,7 @@ TEST_F(SyncSessionTest, EnabledGroupsEmpty) {
scoped_ptr<SyncSession> session(MakeSession());
std::set<ModelSafeGroup> expected_enabled_groups;
expected_enabled_groups.insert(GROUP_PASSIVE);
+ expected_enabled_groups.insert(GROUP_CONTROL);
EXPECT_EQ(expected_enabled_groups, session->GetEnabledGroups());
}
@@ -150,6 +154,7 @@ TEST_F(SyncSessionTest, EnabledGroups) {
scoped_ptr<SyncSession> session(MakeSession());
std::set<ModelSafeGroup> expected_enabled_groups;
expected_enabled_groups.insert(GROUP_PASSIVE);
+ expected_enabled_groups.insert(GROUP_CONTROL);
expected_enabled_groups.insert(GROUP_UI);
expected_enabled_groups.insert(GROUP_DB);
EXPECT_EQ(expected_enabled_groups, session->GetEnabledGroups());
@@ -280,11 +285,15 @@ TEST_F(SyncSessionTest, Coalesce) {
scoped_refptr<ModelSafeWorker> passive_worker(
new FakeModelWorker(GROUP_PASSIVE));
+ scoped_refptr<ModelSafeWorker> control_worker(
+ new FakeModelWorker(GROUP_CONTROL));
scoped_refptr<ModelSafeWorker> db_worker(new FakeModelWorker(GROUP_DB));
scoped_refptr<ModelSafeWorker> ui_worker(new FakeModelWorker(GROUP_UI));
workers_one.push_back(passive_worker);
+ workers_one.push_back(control_worker);
workers_one.push_back(db_worker);
workers_two.push_back(passive_worker);
+ workers_two.push_back(control_worker);
workers_two.push_back(db_worker);
workers_two.push_back(ui_worker);
routes_one[syncable::AUTOFILL] = GROUP_DB;
@@ -295,10 +304,12 @@ TEST_F(SyncSessionTest, Coalesce) {
std::set<ModelSafeGroup> expected_enabled_groups_one;
expected_enabled_groups_one.insert(GROUP_PASSIVE);
+ expected_enabled_groups_one.insert(GROUP_CONTROL);
expected_enabled_groups_one.insert(GROUP_DB);
std::set<ModelSafeGroup> expected_enabled_groups_two;
expected_enabled_groups_two.insert(GROUP_PASSIVE);
+ expected_enabled_groups_two.insert(GROUP_CONTROL);
expected_enabled_groups_two.insert(GROUP_DB);
expected_enabled_groups_two.insert(GROUP_UI);
@@ -337,11 +348,15 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestRemoveOneType) {
scoped_refptr<ModelSafeWorker> passive_worker(
new FakeModelWorker(GROUP_PASSIVE));
+ scoped_refptr<ModelSafeWorker> control_worker(
+ new FakeModelWorker(GROUP_CONTROL));
scoped_refptr<ModelSafeWorker> db_worker(new FakeModelWorker(GROUP_DB));
scoped_refptr<ModelSafeWorker> ui_worker(new FakeModelWorker(GROUP_UI));
workers_one.push_back(passive_worker);
+ workers_one.push_back(control_worker);
workers_one.push_back(db_worker);
workers_two.push_back(passive_worker);
+ workers_two.push_back(control_worker);
workers_two.push_back(db_worker);
workers_two.push_back(ui_worker);
routes_one[syncable::AUTOFILL] = GROUP_DB;
@@ -352,10 +367,12 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestRemoveOneType) {
std::set<ModelSafeGroup> expected_enabled_groups_one;
expected_enabled_groups_one.insert(GROUP_PASSIVE);
+ expected_enabled_groups_one.insert(GROUP_CONTROL);
expected_enabled_groups_one.insert(GROUP_DB);
std::set<ModelSafeGroup> expected_enabled_groups_two;
expected_enabled_groups_two.insert(GROUP_PASSIVE);
+ expected_enabled_groups_two.insert(GROUP_CONTROL);
expected_enabled_groups_two.insert(GROUP_DB);
expected_enabled_groups_two.insert(GROUP_UI);
@@ -381,7 +398,7 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestRemoveOneType) {
std::find(two.workers().begin(), two.workers().end(), ui_worker);
EXPECT_NE(it_db, two.workers().end());
EXPECT_EQ(it_ui, two.workers().end());
- EXPECT_EQ(two.workers().size(), 2U);
+ EXPECT_EQ(two.workers().size(), 3U);
// Make sure the model safe routing info is reduced to one type.
ModelSafeRoutingInfo::const_iterator it =
@@ -407,12 +424,16 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestWithSameType) {
scoped_refptr<ModelSafeWorker> passive_worker(
new FakeModelWorker(GROUP_PASSIVE));
+ scoped_refptr<ModelSafeWorker> control_worker(
+ new FakeModelWorker(GROUP_CONTROL));
scoped_refptr<FakeModelWorker> db_worker(new FakeModelWorker(GROUP_DB));
scoped_refptr<FakeModelWorker> ui_worker(new FakeModelWorker(GROUP_UI));
workers_first.push_back(passive_worker);
+ workers_first.push_back(control_worker);
workers_first.push_back(db_worker);
workers_first.push_back(ui_worker);
workers_second.push_back(passive_worker);
+ workers_second.push_back(control_worker);
workers_second.push_back(db_worker);
workers_second.push_back(ui_worker);
routes_first[syncable::AUTOFILL] = GROUP_DB;
@@ -426,6 +447,7 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestWithSameType) {
std::set<ModelSafeGroup> expected_enabled_groups;
expected_enabled_groups.insert(GROUP_PASSIVE);
+ expected_enabled_groups.insert(GROUP_CONTROL);
expected_enabled_groups.insert(GROUP_DB);
expected_enabled_groups.insert(GROUP_UI);
@@ -455,7 +477,7 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestWithSameType) {
EXPECT_NE(it_passive, second.workers().end());
EXPECT_NE(it_db, second.workers().end());
EXPECT_NE(it_ui, second.workers().end());
- EXPECT_EQ(second.workers().size(), 3U);
+ EXPECT_EQ(second.workers().size(), 4U);
// Make sure the model safe routing info is reduced to first type.
ModelSafeRoutingInfo::const_iterator it1 =
« no previous file with comments | « sync/sessions/sync_session.cc ('k') | sync/sync.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698