Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: sync/engine/resolve_conflicts_command.cc

Issue 10559104: sync: Process 'control' data separately (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename, cleanup, fix tests Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/model_changing_syncer_command_unittest.cc ('k') | sync/engine/sync_scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/resolve_conflicts_command.cc
diff --git a/sync/engine/resolve_conflicts_command.cc b/sync/engine/resolve_conflicts_command.cc
index edef3ff6f22fb965286d8ba56ee94124e4502db4..c9821be7ff2b55d50ee9c9d77d3b745df213b6d6 100644
--- a/sync/engine/resolve_conflicts_command.cc
+++ b/sync/engine/resolve_conflicts_command.cc
@@ -17,7 +17,13 @@ ResolveConflictsCommand::~ResolveConflictsCommand() {}
std::set<ModelSafeGroup> ResolveConflictsCommand::GetGroupsToChange(
const sessions::SyncSession& session) const {
- return session.GetEnabledGroupsWithConflicts();
+ std::set<ModelSafeGroup> groups_with_conflicts =
+ session.GetEnabledGroupsWithConflicts();
+
+ // GROUP_CONTROL conflicts are not handled by this command.
+ groups_with_conflicts.erase(GROUP_CONTROL);
+
+ return groups_with_conflicts;
}
SyncerError ResolveConflictsCommand::ModelChangingExecuteImpl(
« no previous file with comments | « sync/engine/model_changing_syncer_command_unittest.cc ('k') | sync/engine/sync_scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698