Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10559090: Initial commit of the App Host stub. (Closed)

Created:
8 years, 6 months ago by erikwright (departed)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, Jói, grt (UTC plus 2), robertshield
Visibility:
Public.

Description

Initial commit of the App Host stub. This stub will be installed at user level when a user installs Chrome apps. Shortcuts to those Chrome apps should point to the stub, rather than to Chrome. The stub dynamically locates a chrome.exe installed at either user- or system- level, and will eventually even trigger an installation of the Chrome binaries (not Chrome itself) if they are not installed. Once chrome.exe is located, it is launched with the same command-line flags as originally passed to the app host. BUG=None TEST=execute app_host.exe, confirm it launches Chrome. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147526

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
A chrome/browser/extensions/app_host_stub_main.cc View 1 chunk +45 lines, -0 lines 1 comment Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
Hi Erik, Please take a look. The installer work is LGTM'd (blocked on this) here: ...
8 years, 5 months ago (2012-07-18 13:31:00 UTC) #1
miket_OOO
lgtm http://codereview.chromium.org/10559090/diff/1/chrome/browser/extensions/app_host_stub_main.cc File chrome/browser/extensions/app_host_stub_main.cc (right): http://codereview.chromium.org/10559090/diff/1/chrome/browser/extensions/app_host_stub_main.cc#newcode14 chrome/browser/extensions/app_host_stub_main.cc:14: const wchar_t kChromeExe[] = L"chrome.exe"; I'm looking for ...
8 years, 5 months ago (2012-07-19 18:01:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10559090/1
8 years, 5 months ago (2012-07-19 18:26:42 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 20:46:10 UTC) #4
Try job failure for 10559090-1 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698