Add ToString method for easy DLOG and debug support

chrome/common/custom_handlers/protocol_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/custom_handlers/protocol_handler.h"
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "net/base/escape.h"
 
@@ skipping 52 matching lines @@
 }
 
 DictionaryValue* ProtocolHandler::Encode() const {
   DictionaryValue* d = new DictionaryValue();
   d->Set("protocol", Value::CreateStringValue(protocol_));
   d->Set("url", Value::CreateStringValue(url_.spec()));
   d->Set("title", Value::CreateStringValue(title_));
   return d;
 }
 
+std::string ProtocolHandler::ToString() const {
+  return std::string("{ ") +

[Peter Kasting, 2012/06/22 22:10:06]

Nit: I'd probably write/wrap as:

  return "{ protocol=" + protocol_ + ", url=" + url_ + ", title=" + title_ +
      " }";

The more important bits here are, include the trailing underscores on your
variable names, and you can omit the std::string() at the beginning + not place
two spaces in a row if you combine the two opening string constants.  :)

[Steve McKay, 2012/06/22 22:40:01]

Sorry. Mailed before I compiled :(

Had to add some more code to make this compile (since not all fields are
strings). Doesn't really hold up now in the long "less wrapped" form. Happy to
rewrap differently if specify what you want.

+      " protocol=" + protocol +
+      ", url=" + url +
+      ", title=" + title +
+      " }";
+}
+
 bool ProtocolHandler::operator==(const ProtocolHandler& other) const {
   return protocol_ == other.protocol_ &&
     url_ == other.url_ &&
     title_ == other.title_;
 }
 
 bool ProtocolHandler::IsEquivalent(const ProtocolHandler& other) const {
   return protocol_ == other.protocol_ && url_ == other.url_;
 }
 
 bool ProtocolHandler::operator<(const ProtocolHandler& other) const {
   return title_ < other.title_;
 }