Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 10559036: Added URLRequestContext to constructor for URLRequest. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Updated unittests Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/custom_handlers/protocol_handler_registry.h" 5 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/common/chrome_notification_types.h" 12 #include "chrome/common/chrome_notification_types.h"
13 #include "chrome/common/custom_handlers/protocol_handler.h" 13 #include "chrome/common/custom_handlers/protocol_handler.h"
14 #include "chrome/test/base/testing_browser_process.h" 14 #include "chrome/test/base/testing_browser_process.h"
15 #include "chrome/test/base/testing_pref_service.h" 15 #include "chrome/test/base/testing_pref_service.h"
16 #include "chrome/test/base/testing_profile.h" 16 #include "chrome/test/base/testing_profile.h"
17 #include "content/public/browser/notification_observer.h" 17 #include "content/public/browser/notification_observer.h"
18 #include "content/public/browser/notification_registrar.h" 18 #include "content/public/browser/notification_registrar.h"
19 #include "content/public/browser/notification_source.h" 19 #include "content/public/browser/notification_source.h"
20 #include "content/public/test/test_browser_thread.h" 20 #include "content/public/test/test_browser_thread.h"
21 #include "content/public/test/test_renderer_host.h" 21 #include "content/public/test/test_renderer_host.h"
22 #include "net/url_request/url_request.h" 22 #include "net/url_request/url_request.h"
23 #include "net/url_request/url_request_context.h"
23 24
24 using content::BrowserThread; 25 using content::BrowserThread;
25 26
26 namespace { 27 namespace {
27 28
28 class FakeDelegate : public ProtocolHandlerRegistry::Delegate { 29 class FakeDelegate : public ProtocolHandlerRegistry::Delegate {
29 public: 30 public:
30 FakeDelegate() : force_os_failure_(false) {} 31 FakeDelegate() : force_os_failure_(false) {}
31 virtual ~FakeDelegate() { } 32 virtual ~FakeDelegate() { }
32 virtual void RegisterExternalHandler(const std::string& protocol) { 33 virtual void RegisterExternalHandler(const std::string& protocol) {
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 delegate()->set_force_os_failure(true); 642 delegate()->set_force_os_failure(true);
642 registry()->OnAcceptRegisterProtocolHandler(ph_dont); 643 registry()->OnAcceptRegisterProtocolHandler(ph_dont);
643 MessageLoop::current()->Run(); 644 MessageLoop::current()->Run();
644 ASSERT_TRUE(registry()->IsHandledProtocol("do")); 645 ASSERT_TRUE(registry()->IsHandledProtocol("do"));
645 ASSERT_EQ(static_cast<size_t>(1), registry()->GetHandlersFor("do").size()); 646 ASSERT_EQ(static_cast<size_t>(1), registry()->GetHandlersFor("do").size());
646 ASSERT_FALSE(registry()->IsHandledProtocol("dont")); 647 ASSERT_FALSE(registry()->IsHandledProtocol("dont"));
647 ASSERT_EQ(static_cast<size_t>(1), registry()->GetHandlersFor("dont").size()); 648 ASSERT_EQ(static_cast<size_t>(1), registry()->GetHandlersFor("dont").size());
648 } 649 }
649 650
650 static void MakeRequest(const GURL& url, ProtocolHandlerRegistry* registry) { 651 static void MakeRequest(const GURL& url, ProtocolHandlerRegistry* registry) {
651 net::URLRequest request(url, NULL); 652 net::URLRequestContext context;
653 net::URLRequest request(url, NULL, &context);
652 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, 654 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
653 MessageLoop::QuitClosure()); 655 MessageLoop::QuitClosure());
654 scoped_refptr<net::URLRequestJob> job(registry->MaybeCreateJob(&request)); 656 scoped_refptr<net::URLRequestJob> job(registry->MaybeCreateJob(&request));
655 ASSERT_TRUE(job.get() != NULL); 657 ASSERT_TRUE(job.get() != NULL);
656 } 658 }
657 659
658 TEST_F(ProtocolHandlerRegistryTest, TestMaybeCreateTaskWorksFromIOThread) { 660 TEST_F(ProtocolHandlerRegistryTest, TestMaybeCreateTaskWorksFromIOThread) {
659 ProtocolHandler ph1 = CreateProtocolHandler("mailto", "test1"); 661 ProtocolHandler ph1 = CreateProtocolHandler("mailto", "test1");
660 registry()->OnAcceptRegisterProtocolHandler(ph1); 662 registry()->OnAcceptRegisterProtocolHandler(ph1);
661 GURL url("mailto:someone@something.com"); 663 GURL url("mailto:someone@something.com");
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 ASSERT_EQ(ph3.url().GetOrigin() == ph2.url().GetOrigin(), 807 ASSERT_EQ(ph3.url().GetOrigin() == ph2.url().GetOrigin(),
806 ph3.IsSameOrigin(ph2)); 808 ph3.IsSameOrigin(ph2));
807 } 809 }
808 810
809 TEST_F(ProtocolHandlerRegistryTest, TestInstallDefaultHandler) { 811 TEST_F(ProtocolHandlerRegistryTest, TestInstallDefaultHandler) {
810 ReloadProtocolHandlerRegistryAndInstallDefaultHandler(); 812 ReloadProtocolHandlerRegistryAndInstallDefaultHandler();
811 std::vector<std::string> protocols; 813 std::vector<std::string> protocols;
812 registry()->GetRegisteredProtocols(&protocols); 814 registry()->GetRegisteredProtocols(&protocols);
813 ASSERT_EQ(static_cast<size_t>(1), protocols.size()); 815 ASSERT_EQ(static_cast<size_t>(1), protocols.size());
814 } 816 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698