Added URLRequestContext to constructor for URLRequest.

chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h"
 
 #include "base/message_loop.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.h"
 #include "content/public/browser/resource_request_info.h"
@@ skipping 49 matching lines @@
   std::string error;
   ListValue resource_types;
   resource_types.Append(Value::CreateStringValue("main_frame"));
 
   scoped_ptr<WebRequestConditionAttribute> attribute =
       WebRequestConditionAttribute::Create(
           keys::kResourceTypeKey, &resource_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute.get());
 
-  TestURLRequest url_request_ok(GURL("http://www.example.com"), NULL);
+  TestURLRequestContext context;

[mmenke, 2012/06/20 18:33:50]

Is there a reason you're using a TestURLRequestContext here and a
net::URLRequest in protocol_handler_registry_unittest.cc, and the net tests
tests where you added one?

[shalev, 2012/06/20 20:13:12]

I'm trying to maintain existing behavior. Previously, TestURLRequest was
creating a new TestURLRequestContext in its constructor.

In other files, there was no context previously set, so I introduced a blank
net::URLRequestContext.

[mmenke, 2012/06/20 20:24:14]

Ahh...Good point, missed that.  Was looking at the wrong TestURLRequestContext
(Doh!).

+  TestURLRequest url_request_ok(GURL("http://www.example.com"), NULL, &context);
   content::ResourceRequestInfo::AllocateForTesting(&url_request_ok,
       ResourceType::MAIN_FRAME, NULL);
   EXPECT_TRUE(attribute->IsFulfilled(&url_request_ok, ON_BEFORE_REQUEST));
 
-  TestURLRequest url_request_fail(GURL("http://www.example.com"), NULL);
+  TestURLRequest url_request_fail(
+      GURL("http://www.example.com"), NULL, &context);
   content::ResourceRequestInfo::AllocateForTesting(&url_request_ok,
       ResourceType::SUB_FRAME, NULL);
   EXPECT_FALSE(attribute->IsFulfilled(&url_request_fail, ON_BEFORE_REQUEST));
 }
 
 }  // namespace extensions