Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: lib/dartdoc/frog/library.dart

Issue 10559030: Remove uses of string + from API document generator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dartdoc/frog/library.dart
diff --git a/lib/dartdoc/frog/library.dart b/lib/dartdoc/frog/library.dart
index 792cc314583e70489198d272291cfa7b8f1a7174..3a0beefbbb848a0f301222a4fc494d234342857c 100644
--- a/lib/dartdoc/frog/library.dart
+++ b/lib/dartdoc/frog/library.dart
@@ -215,7 +215,7 @@ class Library extends Element {
static String _getDottedName(NameTypeReference type) {
if (type.names != null) {
var names = map(type.names, (n) => n.name);
- return type.name.name + '.' + Strings.join(names, '.');
+ return '${type.name.name}.${Strings.join(names, ".")}';
} else {
return type.name.name;
}
@@ -388,7 +388,7 @@ class _LibraryVisitor implements TreeVisitor {
node.arguments.length == 2 && prefix == null) {
world.error(
'expected at most one "name" argument and one optional "prefix"'
- + ' but found ${node.arguments.length}', node.span);
+ ' but found ${node.arguments.length}', node.span);
} else if (prefix != null && prefix.indexOf('.') >= 0) {
world.error('library prefix canot contain "."', node.span);
} else if (seenSource || seenResource) {
@@ -468,7 +468,7 @@ class _LibraryVisitor implements TreeVisitor {
}
if (args.length > 1) {
world.error('expected at most one "${argName}" argument but found '
- + node.arguments.length, node.span);
+ '${node.arguments.length}', node.span);
}
// Even though the collection has one arg, this is the easiest way to get
// the first item.

Powered by Google App Engine
This is Rietveld 408576698