Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Unified Diff: chrome/browser/password_manager/password_manager_delegate_impl.cc

Issue 10555005: Address bug where the one-click sign-in bar would never show again once (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Unused import, whitespace Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_delegate_impl.cc
===================================================================
--- chrome/browser/password_manager/password_manager_delegate_impl.cc (revision 142386)
+++ chrome/browser/password_manager/password_manager_delegate_impl.cc (working copy)
@@ -6,6 +6,7 @@
#include "base/memory/singleton.h"
#include "base/metrics/histogram.h"
+#include "base/utf_string_conversions.h"
#include "chrome/browser/autofill/autofill_manager.h"
#include "chrome/browser/infobars/infobar_tab_helper.h"
#include "chrome/browser/password_manager/password_form_manager.h"
@@ -139,8 +140,11 @@
// For now, one-click signin is fully implemented only on windows.
#if defined(ENABLE_ONE_CLICK_SIGNIN)
GURL realm(form_to_save->realm());
- if (realm == GURL(GaiaUrls::GetInstance()->gaia_login_form_realm()) &&
- OneClickSigninHelper::CanOffer(tab_contents_->web_contents(), true)) {
+ if ((realm == GURL(GaiaUrls::GetInstance()->gaia_login_form_realm()) ||
Roger Tawa OOO till Jul 10th 2012/06/15 17:56:00 Please open a bug about the full email problem, an
Mathieu 2012/06/21 13:13:00 Done.
+ realm == GURL("https://www.google.com/")) &&
+ OneClickSigninHelper::CanOffer(tab_contents_->web_contents(),
+ UTF16ToUTF8(form_to_save->associated_username()),
+ true)) {
Roger Tawa OOO till Jul 10th 2012/06/15 17:56:00 could put the true on the previous line.
Mathieu 2012/06/21 13:13:00 Done.
return;
}
#endif

Powered by Google App Engine
This is Rietveld 408576698