Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: chrome/browser/password_manager/password_form_manager.h

Issue 10555005: Address bug where the one-click sign-in bar would never show again once (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: lint Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // Handles save-as-new or update of the form managed by this manager. 98 // Handles save-as-new or update of the form managed by this manager.
99 // Note the basic data of updated_credentials must match that of 99 // Note the basic data of updated_credentials must match that of
100 // observed_form_ (e.g DoesManage(pending_credentials_) == true). 100 // observed_form_ (e.g DoesManage(pending_credentials_) == true).
101 void Save(); 101 void Save();
102 102
103 // Call these if/when we know the form submission worked or failed. 103 // Call these if/when we know the form submission worked or failed.
104 // These routines are used to update internal statistics ("ActionsTaken"). 104 // These routines are used to update internal statistics ("ActionsTaken").
105 void SubmitPassed(); 105 void SubmitPassed();
106 void SubmitFailed(); 106 void SubmitFailed();
107 107
108 // Return the username associated with the credentials.
109 const string16& associated_username() const {
110 return pending_credentials_.username_value;
111 }
112
108 // Returns the realm URL for the form managed my this manager. 113 // Returns the realm URL for the form managed my this manager.
109 const std::string& realm() const { 114 const std::string& realm() const {
110 return pending_credentials_.signon_realm; 115 return pending_credentials_.signon_realm;
111 } 116 }
112 117
113 private: 118 private:
114 friend class PasswordFormManagerTest; 119 friend class PasswordFormManagerTest;
115 120
116 // ManagerAction - What does the manager do with this form? Either it 121 // ManagerAction - What does the manager do with this form? Either it
117 // fills it, or it doesn't. If it doesn't fill it, that's either 122 // fills it, or it doesn't. If it doesn't fill it, that's either
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 // These three fields record the "ActionsTaken" by the browser and 254 // These three fields record the "ActionsTaken" by the browser and
250 // the user with this form, and the result. They are combined and 255 // the user with this form, and the result. They are combined and
251 // recorded in UMA when the manager is destroyed. 256 // recorded in UMA when the manager is destroyed.
252 ManagerAction manager_action_; 257 ManagerAction manager_action_;
253 UserAction user_action_; 258 UserAction user_action_;
254 SubmitResult submit_result_; 259 SubmitResult submit_result_;
255 260
256 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager); 261 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
257 }; 262 };
258 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_ 263 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698