Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/webui/certificate_viewer_ui_test-inl.h

Issue 10554010: Remove BrowserList::GetLastActive usage from WebUI pages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: mac build Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/page_info_bubble_view.cc ('K') | « chrome/test/base/test_browser_window.h ('k') | ui/web_dialogs/constrained_web_dialog_ui.h » ('j') | ui/web_dialogs/constrained_web_dialog_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/certificate_viewer_ui_test-inl.h
===================================================================
--- chrome/test/data/webui/certificate_viewer_ui_test-inl.h (revision 142088)
+++ chrome/test/data/webui/certificate_viewer_ui_test-inl.h (working copy)
@@ -38,7 +38,8 @@
CertificateViewerDialog* dialog = new CertificateViewerDialog(
google_cert);
dialog->AddObserver(&dialog_observer);
- dialog->Show(browser()->window()->GetNativeWindow());
+ dialog->Show(browser()->GetActiveWebContents(),
+ browser()->window()->GetNativeWindow());
dialog->RemoveObserver(&dialog_observer);
content::WebUI* webui = dialog_observer.GetWebUI();
webui->GetWebContents()->GetRenderViewHost()->SetWebUIProperty(
« chrome/browser/ui/views/page_info_bubble_view.cc ('K') | « chrome/test/base/test_browser_window.h ('k') | ui/web_dialogs/constrained_web_dialog_ui.h » ('j') | ui/web_dialogs/constrained_web_dialog_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698