Move content::URLFetcher static functions to net::URLFetcher

content/common/net/url_fetcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[wtc, 2012/06/18 23:04:22]

The CL's description says:
  Move content/common/net/url_fetcher.cc to content/public/common.

But this file isn't moved.  Perhaps the CL's description is
out of date?

[akalin, 2012/06/18 23:12:32]

Yeah, you're right.  Fixed.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/url_fetcher.h"
 
 #include "base/bind.h"
 #include "content/common/net/url_request_user_data.h"
-#include "net/url_request/url_fetcher_factory.h"
-#include "net/url_request/url_fetcher_impl.h"
+#include "net/url_request/url_fetcher.h"
 
-// static
-net::URLFetcher* content::URLFetcher::Create(
+namespace content {
+
+namespace URLFetcher {

[wtc, 2012/06/18 23:04:22]

This doesn't confirm to our Style Guide?  All the namespace names
I have seen are all lowercase.  I guess the URLFetcher
namespace is just a temporary solution to the rlz problem?

[akalin, 2012/06/18 23:12:32]

Yeah, it's just a temporary hack.  It should go away quickly once this gets
checked in. (thakis promised to fix rlz once I ping him.)

+
+net::URLFetcher* Create(
     const GURL& url,
     net::URLFetcher::RequestType request_type,
     net::URLFetcherDelegate* d) {
-  return new net::URLFetcherImpl(url, request_type, d);
+  return net::URLFetcher::Create(url, request_type, d);
 }
 
-// static
-net::URLFetcher* content::URLFetcher::Create(
-    int id,
-    const GURL& url,
-    net::URLFetcher::RequestType request_type,
-    net::URLFetcherDelegate* d) {
-  net::URLFetcherFactory* factory = net::URLFetcherImpl::factory();
-  return factory ? factory->CreateURLFetcher(id, url, request_type, d) :
-                   new net::URLFetcherImpl(url, request_type, d);
-}
-
-// static
-void content::URLFetcher::CancelAll() {
-  net::URLFetcherImpl::CancelAll();
-}
-
-// static
-void content::URLFetcher::SetEnableInterceptionForTests(bool enabled) {
-  net::URLFetcherImpl::SetEnableInterceptionForTests(enabled);
-}
+}  // namespace URLFetcher
 
 namespace {
 
 base::SupportsUserData::Data* CreateURLRequestUserData(
     int render_process_id,
     int render_view_id) {
   return new URLRequestUserData(render_process_id, render_view_id);
 }
 
 }  // namespace
 
-namespace content {
-
 void AssociateURLFetcherWithRenderView(net::URLFetcher* url_fetcher,
                                        const GURL& first_party_for_cookies,
                                        int render_process_id,
                                        int render_view_id) {
   url_fetcher->SetFirstPartyForCookies(first_party_for_cookies);
   url_fetcher->SetURLRequestUserData(
       URLRequestUserData::kUserDataKey,
       base::Bind(&CreateURLRequestUserData,
                  render_process_id, render_view_id));
 }
 
 }  // namespace content