Handle interface to prerenders.

chrome/browser/prerender/prerender_link_manager.cc

Index: chrome/browser/prerender/prerender_link_manager.cc
diff --git a/chrome/browser/prerender/prerender_link_manager.cc b/chrome/browser/prerender/prerender_link_manager.cc
index c12e6cce61b5123ad9fa5e93e3cbfcb75c6b9b3b..22bf8e29d17f0d3c530e752694a04c7141b50a96 100644
--- a/chrome/browser/prerender/prerender_link_manager.cc
+++ b/chrome/browser/prerender/prerender_link_manager.cc
@@ -9,6 +9,7 @@
 #include <utility>
 
 #include "chrome/browser/prerender/prerender_contents.h"
+#include "chrome/browser/prerender/prerender_handle.h"

[dominich, 2012/06/28 00:34:32]

unnecessary include - included in header.

 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/profiles/profile.h"
@@ -50,14 +51,16 @@ bool PrerenderLinkManager::OnAddPrerender(int child_id,
   replacements.ClearRef();
   const GURL url = orig_url.ReplaceComponents(replacements);
 
-  if (!manager_->AddPrerenderFromLinkRelPrerender(
-          child_id, render_view_route_id, url, referrer, size)) {
-    return false;
+  if (PrerenderHandle prerender_handle =
+          manager_->AddPrerenderFromLinkRelPrerender(
+              child_id, render_view_route_id, url, referrer, size)) {
+    ChildAndPrerenderIdPair child_and_prerender_id(child_id, prerender_id);
+    DCHECK_EQ(0U, ids_to_handle_map_.count(child_and_prerender_id));

[dominich, 2012/06/28 00:34:32]

in the case of multiple prerenders, this could happen if a web dev adds multiple
link rel prerender elements referencing the same URL.

[mmenke, 2012/06/28 16:01:28]

Could happen in the case of supporting one prerender at a time, too, since that
rule is handled by the PrerenderManager.

+    ids_to_handle_map_.insert(
+        std::make_pair(child_and_prerender_id, prerender_handle));
+    return true;
   }
-  const ChildAndPrerenderIdPair child_and_prerender_id(child_id, prerender_id);
-  DCHECK_EQ(0U, ids_to_url_map_.count(child_and_prerender_id));
-  ids_to_url_map_.insert(std::make_pair(child_and_prerender_id, url));
-  return true;
+  return false;
 }
 
 // TODO(gavinp): Once an observer interface is provided down to the WebKit
@@ -69,15 +72,18 @@ void PrerenderLinkManager::OnCancelPrerender(int child_id, int prerender_id) {
   DVLOG(2) << "OnCancelPrerender, child_id = " << child_id
            << ", prerender_id = " << prerender_id;
   const ChildAndPrerenderIdPair child_and_prerender_id(child_id, prerender_id);
-  IdPairToUrlMap::iterator id_url_iter =
-      ids_to_url_map_.find(child_and_prerender_id);
-  if (id_url_iter == ids_to_url_map_.end()) {
+  IdPairToPrerenderHandleMap::iterator id_handle_iter =
+      ids_to_handle_map_.find(child_and_prerender_id);
+  if (id_handle_iter == ids_to_handle_map_.end()) {
     DVLOG(5) << "... canceling a prerender that doesn't exist.";
     return;
   }
-  const GURL url = id_url_iter->second;
-  ids_to_url_map_.erase(id_url_iter);
-  manager_->MaybeCancelPrerender(url);
+  if (PrerenderHandle prerender_handle = id_handle_iter->second)
+    prerender_handle->Release();
+  else
+    DVLOG(5) << "... and the handle was no good.";

[dominich, 2012/06/28 00:34:32]

does this ever happen? maybe DCHECK instead.

+
+  ids_to_handle_map_.erase(id_handle_iter);
 }
 
 void PrerenderLinkManager::OnAbandonPrerender(int child_id, int prerender_id) {
@@ -86,7 +92,7 @@ void PrerenderLinkManager::OnAbandonPrerender(int child_id, int prerender_id) {
   // TODO(gavinp,cbentzel): Implement reasonable behaviour for
   // navigation away from launcher.
   const ChildAndPrerenderIdPair child_and_prerender_id(child_id, prerender_id);
-  ids_to_url_map_.erase(child_and_prerender_id);
+  ids_to_handle_map_.erase(child_and_prerender_id);
 }
 
 void PrerenderLinkManager::OnChannelClosing(int child_id) {
@@ -96,9 +102,9 @@ void PrerenderLinkManager::OnChannelClosing(int child_id) {
   const ChildAndPrerenderIdPair child_and_maximum_prerender_id(
       child_id, std::numeric_limits<int>::max());
   std::queue<int> prerender_ids_to_abandon;
-  for (IdPairToUrlMap::iterator
-           i = ids_to_url_map_.lower_bound(child_and_minimum_prerender_id),
-           e = ids_to_url_map_.upper_bound(child_and_maximum_prerender_id);
+  for (IdPairToPrerenderHandleMap::iterator
+           i = ids_to_handle_map_.lower_bound(child_and_minimum_prerender_id),
+           e = ids_to_handle_map_.upper_bound(child_and_maximum_prerender_id);
        i != e; ++i) {
     prerender_ids_to_abandon.push(i->first.second);
   }
@@ -111,7 +117,7 @@ void PrerenderLinkManager::OnChannelClosing(int child_id) {
 }
 
 bool PrerenderLinkManager::IsEmpty() const {
-  return ids_to_url_map_.empty();
+  return ids_to_handle_map_.empty();
 }
 
 }  // namespace prerender