Handle interface to prerenders.

chrome/browser/prerender/prerender_handle.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PRERENDER_PRERENDER_HANDLE_H_
+#define CHROME_BROWSER_PRERENDER_PRERENDER_HANDLE_H_
+
+#include "base/threading/non_thread_safe.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+
+class GURL;
+
+namespace content {
+class SessionStorageNamespace;
+}
+
+namespace prerender {
+
+class PrerenderContents;
+class PrerenderManager;
+
+class PrerenderHandle : public base::SupportsWeakPtr<PrerenderHandle>,
+                        public base::NonThreadSafe {

[dominich, 2012/06/22 15:36:16]

consider making this refcounted directly and see if that clears up some of the
client code.

+ public:
+  ~PrerenderHandle();
+
+  bool Matches(
+      const GURL& url,
+      const content::SessionStorageNamespace* session_storage_namespace) const;
+
+  bool IsPending() const;
+  bool IsPrerendering() const { return !IsPending(); }
+
+  bool DidFinishLoading() const;
+
+  void DecrementClientCount();
+
+ private:
+  friend class PrerenderManager;
+
+  PrerenderHandle();
+
+  void AddDuplicate(scoped_ptr<PrerenderHandle> new_duplicate_handle);
+
+  PrerenderContents* contents() const { return contents_; }

[dominich, 2012/06/22 15:36:16]

not sure i understand the point of an accessor at the same accessibility level
as the field.

[mmenke, 2012/06/22 16:12:45]

I generally do it when something is called by a friend class, at least if the
friend class is not the outer class, to make it clearer which variables are
accessed semi-externally.

+  void SetContents(PrerenderContents* contents);
+
+  PrerenderContents* contents_;
+
+  // Another prerender handle, owned by this one, which refers to the same
+  // PrerenderContents.

[dominich, 2012/06/22 15:36:16]

what for?

+  scoped_ptr<PrerenderHandle> duplicate_handle_;
+};
+
+}  // namespace prerender
+
+#endif  // CHROME_BROWSER_PRERENDER_PRERENDER_HANDLE_H_