Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1055003: Restore http://code.google.com/p/v8/source/detail?r=4151 fixing a typo: (Closed)

Created:
10 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Restore http://code.google.com/p/v8/source/detail?r=4151 fixing a typo: index d545c34..91cb151 100644 --- a/src/builtins.cc +++ b/src/builtins.cc @@ -738,7 +738,7 @@ BUILTIN(ArrayConcat) { int result_len = 0; for (int i = 0; i < n_arguments; i++) { Object* arg = args[i]; - if (!arg->IsJSArray() || JSArray::cast(arg)->HasFastElements()) { + if (!arg->IsJSArray() || !JSArray::cast(arg)->HasFastElements()) { return CallJsBuiltin("ArrayConcat", args); } This reverts 4153. # Please enter the commit message for your changes. Lines starting Committed: http://code.google.com/p/v8/source/detail?r=4154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M src/builtins.cc View 2 chunks +31 lines, -26 lines 0 comments Download
M src/v8-counters.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
10 years, 9 months ago (2010-03-17 09:37:18 UTC) #1
antonm
Please, let me know if you'd rather me wait for next trunk push
10 years, 9 months ago (2010-03-17 09:38:05 UTC) #2
Mads Ager (chromium)
10 years, 9 months ago (2010-03-17 09:39:16 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698