Synchronize the check status of the "Check Spelling While Typing" item.

chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h"
 
 #include <cmath>
 
 #include "base/mac/closure_blocks_leopard_compat.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/debugger/devtools_window.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #import "chrome/browser/ui/cocoa/history_overlay_controller.h"
 #import "chrome/browser/ui/cocoa/view_id_util.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/spellcheck_messages.h"
 #include "chrome/common/url_constants.h"
+#include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_view_host_observer.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 
 using content::RenderViewHost;
 
 // Declare things that are part of the 10.7 SDK.
 #if !defined(MAC_OS_X_VERSION_10_7) || \
@@ skipping 254 matching lines @@
   // For now, this action is always enabled for render view;
   // this is sub-optimal.
   // TODO(suzhe): Plumb the "can*" methods up from WebCore.
   if (action == @selector(checkSpelling:)) {
     *valid = renderWidgetHost_->IsRenderView();
     return YES;
   }
 
   if (action == @selector(toggleContinuousSpellChecking:)) {
     if ([(id)item respondsToSelector:@selector(setState:)]) {
+      content::RenderProcessHost* host = renderWidgetHost_->GetProcess();
+      Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
+      if (profile) {

[jeremy, 2012/06/19 12:14:43]

Is this null check still needed?

[Hironori Bono, 2012/06/21 09:38:18]

Thanks for your comment. In my honest opinion, I have not tested this menu-bar
code thoroughly. (I tested only on my Snow-Leopard Mac.) As far as I tested on
my Mac, it is OK to remove this NULL check and I have replaced this check with a
DCHECK().

+        spellcheckChecked_ =
+            profile->GetPrefs()->GetBoolean(prefs::kEnableSpellCheck);
+      }
       NSCellStateValue checkedState =
           spellcheckChecked_ ? NSOnState : NSOffState;
       [(id)item setState:checkedState];
     }
     *valid = spellcheckEnabled_;
     return YES;
   }
 
   return NO;
 }
@@ skipping 36 matching lines @@
     spellcheck_mac::IgnoreWord(base::SysNSStringToUTF16(wordToIgnore));
 }
 
 - (void)showGuessPanel:(id)sender {
   renderWidgetHost_->Send(new SpellCheckMsg_ToggleSpellPanel(
       renderWidgetHost_->GetRoutingID(),
       spellcheck_mac::SpellingPanelVisible()));
 }
 
 - (void)toggleContinuousSpellChecking:(id)sender {
+  content::RenderProcessHost* host = renderWidgetHost_->GetProcess();
+  Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
+  if (profile) {

[jeremy, 2012/06/19 12:14:43]

Same question here

[Hironori Bono, 2012/06/21 09:38:18]

Done.

+    PrefService* pref = profile->GetPrefs();
+    pref->SetBoolean(prefs::kEnableSpellCheck,
+                     !pref->GetBoolean(prefs::kEnableSpellCheck));
+  }
   renderWidgetHost_->Send(
       new SpellCheckMsg_ToggleSpellCheck(renderWidgetHost_->GetRoutingID()));
 }
 
 - (void)spellCheckEnabled:(BOOL)enabled checked:(BOOL)checked {
   spellcheckEnabled_ = enabled;
   spellcheckChecked_ = checked;
 }
 
 // END Spellchecking methods
 
 @end