Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: content/browser/dom_storage/session_storage_namespace_impl.h

Issue 10546167: Create and store persistent unique ids for sessionStorage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/dom_storage/session_storage_namespace_impl.h
diff --git a/content/browser/dom_storage/session_storage_namespace_impl.h b/content/browser/dom_storage/session_storage_namespace_impl.h
index 4c74ac8656335275efe8168e16b2e84d608c72c5..379d7ea5eb386cbd4927b0d71be7485cbd83b8d3 100644
--- a/content/browser/dom_storage/session_storage_namespace_impl.h
+++ b/content/browser/dom_storage/session_storage_namespace_impl.h
@@ -20,10 +20,20 @@ class DomStorageSession;
class SessionStorageNamespaceImpl
: NON_EXPORTED_BASE(public content::SessionStorageNamespace) {
public:
+ // Constructs a |SessionStorageNamespaceImpl| and allocates new IDs for it.
explicit SessionStorageNamespaceImpl(DOMStorageContextImpl* context);
+
+ // Constructs a |SessionStorageNamespaceImpl| by cloning
+ // |namespace_to_clone|. Allocates new IDs for it.
SessionStorageNamespaceImpl(DOMStorageContextImpl* context,
int64 namepace_id_to_clone);
- int64 id() const;
+
+ // Constructs a |SessionStorageNamespaceImpl| and assigns |persistent_id|
+ // to it. Allocates a new non-persistent ID.
+ SessionStorageNamespaceImpl(DOMStorageContextImpl* context,
+ const std::string& persistent_id);
+ virtual int64 id() const OVERRIDE;
jochen (gone - plz use gerrit) 2012/06/15 13:57:21 can you move the virtual methods in a separate blo
marja 2012/06/15 14:31:32 Done.
+ virtual const std::string& persistent_id() const OVERRIDE;
SessionStorageNamespaceImpl* Clone();
private:

Powered by Google App Engine
This is Rietveld 408576698