Chromium Code Reviews| Index: cloud_print/service/service.gyp |
| diff --git a/cloud_print/service/service.gyp b/cloud_print/service/service.gyp |
| index 096e0d8ff9d354282563b4a6999adb980ea155a6..a905e3d8d353ff5eecea14ccec2d7d121efa99f4 100644 |
| --- a/cloud_print/service/service.gyp |
| +++ b/cloud_print/service/service.gyp |
| @@ -26,7 +26,14 @@ |
| 'service_switches.h', |
| 'win/chrome_launcher.cc', |
| 'win/chrome_launcher.h', |
| - ] |
| + ], |
| + 'conditions': [ |
| + ['OS=="win"', { |
|
Vitaly Buka (NO REVIEWS)
2012/06/13 18:01:36
What if you remove condition here?
erikwright (departed)
2012/06/13 19:43:43
launcher_support is only built/meaningful on Windo
|
| + 'dependencies': [ |
| + '<(DEPTH)/chrome/chrome.gyp:launcher_support', |
| + ], |
| + }, ], |
|
grt (UTC plus 2)
2012/06/13 18:00:10
unless you copied "}, ]," from somewhere, please c
Vitaly Buka (NO REVIEWS)
2012/06/13 18:08:19
Please one per line here.
On 2012/06/13 18:00:10,
erikwright (departed)
2012/06/13 19:43:43
Done.
erikwright (departed)
2012/06/13 19:43:43
Did you mean only one comma or only one close-brac
Vitaly Buka (NO REVIEWS)
2012/06/13 20:18:37
Never mind.
It's good now.
On 2012/06/13 19:43:43
|
| + ], |
| }, |
| { |
| 'target_name': 'cloud_print_service', |