Factor out logic to find chrome.exe from Omaha client state.

chrome/tools/launcher_support/chrome_launcher_support.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_TOOLS_LAUNCHER_SUPPORT_CHROME_LAUNCHER_SUPPORT_H_
+#define CHROME_TOOLS_LAUNCHER_SUPPORT_CHROME_LAUNCHER_SUPPORT_H_
+

[grt (UTC plus 2), 2012/06/13 18:00:10]

#pragma once

[erikwright (departed), 2012/06/13 19:43:43]

Done.

+class FilePath;

[grt (UTC plus 2), 2012/06/13 18:00:10]

since FilePath is used directly rather than just a pointer or reference to it, i
think you must include base/file_path.h rather than forward decl'ing.

[erikwright (departed), 2012/06/13 19:43:43]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Header...

"How can we use a class Foo in a header file without access to its definition?
... We can declare (but not define) functions with arguments, and/or return
values, of type Foo."

+
+namespace chrome_launcher_support {

[grt (UTC plus 2), 2012/06/13 18:00:10]

please document the declarations in this file.

[erikwright (departed), 2012/06/13 19:43:43]

Done.

+
+enum InstallationLevel {
+  USER_LEVEL_INSTALLATION,
+  SYSTEM_LEVEL_INSTALLATION
+};
+
+FilePath GetAnyChromePath();

[robertshield, 2012/06/13 18:01:53]

could you add a comment to these methods (mainly the first one, which is
somewhat confusingly named).

[erikwright (departed), 2012/06/13 19:43:43]

Done.

+FilePath GetChromePathForInstallationLevel(InstallationLevel level);
+
+}  // namespace chrome_launcher_support
+
+#endif  // CHROME_TOOLS_LAUNCHER_SUPPORT_CHROME_LAUNCHER_SUPPORT_H_