ash: Fix the border colors in the uber-tray popup.

ash/system/tray/system_tray_bubble.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray_bubble.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_item.h"
@@ skipping 15 matching lines @@
 
 const int kAnimationDurationForPopupMS = 200;
 
 // Normally a detailed view is the same size as the default view. However,
 // when showing a detailed view directly (e.g. clicking on a notification),
 // we may not know the height of the default view, or the default view may
 // be too short, so we use this as a default and minimum height for any
 // detailed view.
 const int kDetailedBubbleMaxHeight = kTrayPopupItemHeight * 5;
 
+class TrayPopupItemBorder : public views::Border {
+ public:
+  explicit TrayPopupItemBorder(views::View* owner) : owner_(owner) {}
+  virtual ~TrayPopupItemBorder() {}
+
+ private:
+  // Overridden from views::Border.
+  virtual void Paint(const views::View& view,
+                     gfx::Canvas* canvas) const OVERRIDE {
+    const views::View* parent = view.parent();

[sky, 2012/06/13 16:22:35]

Do you really ever paint with no parent?

[sadrul, 2012/06/13 16:39:20]

Good point. Removed this NULL check

+    if (!parent)
+      return;
+    int index = parent->GetIndexOf(&view);
+
+    // Draw a dark top-border for the first item.
+    if (index == 0)
+      canvas->FillRect(gfx::Rect(0, 0, view.width(), 1), kBorderDarkColor);
+
+    // Bottom border.
+    if (index != parent->child_count() - 1) {
+      canvas->FillRect(gfx::Rect(0, view.height() - 1, view.width(), 1),
+                       kBorderLightColor);
+    }
+
+    // Left and right borders.
+    canvas->FillRect(gfx::Rect(0, 0, 1, view.height()), kBorderDarkColor);
+    canvas->FillRect(gfx::Rect(view.width() - 1, 0, 1, view.height()),
+        kBorderDarkColor);
+  }
+
+  virtual void GetInsets(gfx::Insets* insets) const OVERRIDE {
+    const views::View* parent = owner_->parent();
+    if (!parent)
+      return;
+    int index = parent->GetIndexOf(owner_);
+    insets->Set(index == 0, 1, index != parent->child_count() - 1, 1);
+  }
+
+  views::View* owner_;
+
+  DISALLOW_COPY_AND_ASSIGN(TrayPopupItemBorder);
+};
+
 // A view with some special behaviour for tray items in the popup:
 // - changes background color on hover.
 class TrayPopupItemContainer : public views::View {
  public:
   explicit TrayPopupItemContainer(views::View* view) : hover_(false) {
     set_notify_enter_exit_on_child(true);
-    set_border(view->border() ? views::Border::CreateEmptyBorder(0, 0, 0, 0) :
-        views::Border::CreateSolidSidedBorder(1, 1, 0, 1, kBorderDarkColor));
+    set_border(new TrayPopupItemBorder(this));
     views::BoxLayout* layout = new views::BoxLayout(
         views::BoxLayout::kVertical, 0, 0, 0);
     layout->set_spread_blank_space(true);
     SetLayoutManager(layout);
     SetPaintToLayer(view->layer() != NULL);
     if (view->layer())
       SetFillsBoundsOpaquely(view->layer()->fills_bounds_opaquely());
     AddChildView(view);
     SetVisible(view->visible());
   }
@@ skipping 396 matching lines @@
 }
 
 void SystemTrayBubble::OnWidgetClosing(views::Widget* widget) {
   CHECK_EQ(bubble_widget_, widget);
   bubble_widget_ = NULL;
   tray_->RemoveBubble(this);
 }
 
 }  // namespace internal
 }  // namespace ash