gdata: Move ownership of GDataCache to GDataSystemService

chrome/browser/chromeos/gdata/gdata_system_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_system_service.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
@@ skipping 10 matching lines @@
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserContext;
 using content::BrowserThread;
 
 namespace gdata {
 
 //===================== GDataSystemService ====================================
 GDataSystemService::GDataSystemService(Profile* profile)
     : profile_(profile),
+      sequence_token_(BrowserThread::GetBlockingPool()->GetSequenceToken()),
+      cache_(

[achuithb, 2012/06/12 08:17:43]

I think GDataCache creation needs to happen on the blocking pool. I think this
is will be quite problematic because you need to PostTaskAndReply to the
blocking pool, then after creation, set the cache_ pointer in file_system_.
Until this finishes, file_system_ can't really be used. 

[hashimoto, 2012/06/12 08:22:55]

Current code creates GDataCache on the UI thread, can we do it later in a
separated patch set?  I think this may be somehow tricky change and will have a
good chance to get reverted.

[achuithb, 2012/06/12 08:36:54]

Yea - can we add back the comment and TODO then?

[hashimoto, 2012/06/12 08:40:51]

Done.

+          GDataCache::CreateGDataCache(GDataCache::GetCacheRootPath(profile_),
+                                       BrowserThread::GetBlockingPool(),
+                                       sequence_token_)),
       documents_service_(new DocumentsService),
-      file_system_(new GDataFileSystem(profile, docs_service())),
+      file_system_(new GDataFileSystem(profile,
+                                       cache(),
+                                       docs_service(),
+                                       sequence_token_)),
       uploader_(new GDataUploader(file_system(), docs_service())),
       download_observer_(new GDataDownloadObserver),
-      sync_client_(new GDataSyncClient(profile, file_system())),
+      sync_client_(new GDataSyncClient(profile, file_system(), cache())),
       webapps_registry_(new DriveWebAppsRegistry) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 }
 
 GDataSystemService::~GDataSystemService() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(sequence_token_)
+      ->PostTask(
+          FROM_HERE,
+          base::Bind(&base::DeletePointer<GDataCache>, cache_.release()));
 }
 
 void GDataSystemService::Initialize() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // This order is necessary so the sync_client_ doesn't miss
   // OnCacheInitialized() notification.
   sync_client_->Initialize();
   file_system_->Initialize();
 
   content::DownloadManager* download_manager =
     g_browser_process->download_status_updater() ?
         BrowserContext::GetDownloadManager(profile_) : NULL;
   download_observer_->Initialize(
       uploader_.get(),
       download_manager,
-      file_system_->GetCacheDirectoryPath(
+      cache_->GetCacheDirectoryPath(
           GDataCache::CACHE_TYPE_TMP_DOWNLOADS));
 }
 
 void GDataSystemService::Shutdown() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // Shut down the member objects in the reverse order of creation.
   webapps_registry_.reset();
   sync_client_.reset();
   download_observer_.reset();
@@ skipping 33 matching lines @@
 }
 
 ProfileKeyedService* GDataSystemServiceFactory::BuildServiceInstanceFor(
     Profile* profile) const {
   GDataSystemService* service = new GDataSystemService(profile);
   service->Initialize();
   return service;
 }
 
 }  // namespace gdata