Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: chrome/test/base/testing_profile.h

Issue 10546083: Convert ProtocolHandlerRegistry to be a ProfileKeyedService. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Don't create PHR instances via TestProfile. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/testing_profile.h
diff --git a/chrome/test/base/testing_profile.h b/chrome/test/base/testing_profile.h
index ceba5cdea9ba264144f4a47e4e28d027d928cdc7..643fdb4ddf26857ab4ac3aaa4c52a1c451f996c7 100644
--- a/chrome/test/base/testing_profile.h
+++ b/chrome/test/base/testing_profile.h
@@ -94,10 +94,6 @@ class TestingProfile : public Profile {
// BlockUntilBookmarkModelLoaded.
void CreateBookmarkModel(bool delete_file);
- // Creates a ProtocolHandlerRegistry. If not invoked the protocol handler
- // registry is NULL.
- void CreateProtocolHandlerRegistry();
-
// Creates a WebDataService. If not invoked, the web data service is NULL.
void CreateWebDataService();
@@ -200,7 +196,6 @@ class TestingProfile : public Profile {
virtual ProtocolHandlerRegistry* GetProtocolHandlerRegistry() OVERRIDE;
virtual void MarkAsCleanShutdown() OVERRIDE {}
virtual void InitPromoResources() OVERRIDE {}
- virtual void InitRegisteredProtocolHandlers() OVERRIDE {}
virtual FilePath last_selected_directory() OVERRIDE;
virtual void set_last_selected_directory(const FilePath& path) OVERRIDE;
@@ -257,7 +252,7 @@ class TestingProfile : public Profile {
// The ProtocolHandlerRegistry. Only created if CreateProtocolHandlerRegistry
// is invoked.
- scoped_refptr<ProtocolHandlerRegistry> protocol_handler_registry_;
+ ProtocolHandlerRegistry* protocol_handler_registry_;
Elliot Glaysher 2012/06/22 17:32:48 Is this ever used now? If not, cut it out.
Steve McKay 2012/06/22 18:01:58 Nope. Nuked!
// The policy service. Lazily created as a stub.
scoped_ptr<policy::PolicyService> policy_service_;

Powered by Google App Engine
This is Rietveld 408576698