Convert ProtocolHandlerRegistry to be a ProfileKeyedService.

chrome/browser/profiles/profile_io_data.h

Index: chrome/browser/profiles/profile_io_data.h
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index 64631c58a37fe4bf688a0bb8f5e078a786b8dbd6..133e25d249134657ea1b689793194c710d653af8 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -19,6 +19,7 @@
 #include "chrome/browser/prefs/pref_member.h"
 #include "content/public/browser/resource_context.h"
 #include "net/cookies/cookie_monster.h"
+#include "net/url_request/url_request_job_factory.h"
 
 class CookieSettings;
 class DesktopNotificationService;
@@ -158,7 +159,12 @@ class ProfileIOData {
     DesktopNotificationService* notification_service;
 #endif
 
-    scoped_refptr<ProtocolHandlerRegistry> protocol_handler_registry;
+    // This pointer exists only as a means of conveying the
+    // pointer from the factory on the UI thread to the consumer
+    // (URLRequestJobFactory) on the IO thread. Once delivered,
+    // URLRequestJobFactory assumes ownership of the pointer.
+    net::URLRequestJobFactory::Interceptor* protocol_handler_url_interceptor;

[willchan no longer on Chromium, 2012/06/22 19:01:56]

I believe this will lead to leaks. Sometimes we create a Profile and a
ProfileIOData, but never initialize the ProfileIOData, since it's done lazily,
so the transfer of ownership to the URLRequestJobFactory never happens. This
will cause issues on our memory bots. You should keep this within a scoped_ptr
and use .release() to perform the explicit transfer.

[Steve McKay, 2012/06/27 21:49:28]

Great tip. Done!

+
     // We need to initialize the ProxyConfigService from the UI thread
     // because on linux it relies on initializing things through gconf,
     // and needs to be on the main thread.