Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: chrome/browser/profiles/profile.h

Issue 10546083: Convert ProtocolHandlerRegistry to be a ProfileKeyedService. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Respond to review comments. Fit and finish. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile.h
diff --git a/chrome/browser/profiles/profile.h b/chrome/browser/profiles/profile.h
index d84c9a0ef9b92cf9eaa6d4b712b108dfda97d488..76bee5aa2de666fff484aad948258c0f39efcb01 100644
--- a/chrome/browser/profiles/profile.h
+++ b/chrome/browser/profiles/profile.h
@@ -296,6 +296,7 @@ class Profile : public content::BrowserContext {
virtual BookmarkModel* GetBookmarkModel() = 0;
// Returns the ProtocolHandlerRegistry, creating if not yet created.
+ // TODO(smckay): replace this with access via ProtocolHandlerRegistryFactory.
virtual ProtocolHandlerRegistry* GetProtocolHandlerRegistry() = 0;
// Return whether 2 profiles are the same. 2 profiles are the same if they
@@ -319,10 +320,6 @@ class Profile : public content::BrowserContext {
// Start up service that gathers data from a promo resource feed.
virtual void InitPromoResources() = 0;
- // Register URLRequestFactories for protocols registered with
- // registerProtocolHandler.
- virtual void InitRegisteredProtocolHandlers() = 0;
Steve McKay 2012/06/14 04:05:04 FYI, this is now handled by the factory which is c
-
// Returns the last directory that was chosen for uploading or opening a file.
virtual FilePath last_selected_directory() = 0;
virtual void set_last_selected_directory(const FilePath& path) = 0;

Powered by Google App Engine
This is Rietveld 408576698