Use different help URLs for menus, accelerators, and WebUI.

chrome/browser/app_controller_mac.mm

Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 084113688bb2dcd0271b73d44170c9a9a659e676..fb9f88dfb8294cad9f9d2eb701ec86deee44e827 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -891,12 +891,17 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
       else
         Browser::OpenExtensionsWindow(lastProfile);
       break;
-    case IDC_HELP_PAGE:
+    case IDC_HELP_PAGE_VIA_KEYBOARD:
+    case IDC_HELP_PAGE_VIA_MENU: {
+      Browser::HelpSource source = (tag == IDC_HELP_PAGE_VIA_KEYBOARD) ?
+                                   Browser::HELP_SOURCE_KEYBOARD :
+                                   Browser::HELP_SOURCE_MENU;
       if (Browser* browser = ActivateBrowser(lastProfile))
-        browser->ShowHelpTab();
+        browser->ShowHelpTab(source);
       else
-        Browser::OpenHelpWindow(lastProfile);
+        Browser::OpenHelpWindow(lastProfile, source);
       break;
+    }
     case IDC_SHOW_SYNC_SETUP:
       if (Browser* browser = ActivateBrowser(lastProfile))
         browser->ShowSyncSetup(SyncPromoUI::SOURCE_MENU);
@@ -1024,7 +1029,7 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
   menuState_->UpdateCommandEnabled(IDC_SHOW_HISTORY, true);
   menuState_->UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true);
   menuState_->UpdateCommandEnabled(IDC_MANAGE_EXTENSIONS, true);
-  menuState_->UpdateCommandEnabled(IDC_HELP_PAGE, true);
+  menuState_->UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);

[Daniel Erat, 2012/06/08 21:07:11]

Should I also be calling this for IDC_HELP_PAGE_VIA_KEYBOARD?  Is there an
additional file that I should be editing for Mac?

[Avi (use Gerrit), 2012/06/11 20:54:06]

There's no "help" keyboard shortcut on the Mac; I don't know how
IDC_HELP_PAGE_VIA_KEYBOARD would be triggered.

[Daniel Erat, 2012/06/11 21:05:37]

Thanks, that answers it.  I've removed IDC_HELP_PAGE_VIA_KEYBOARD from
commandDispatch.

   menuState_->UpdateCommandEnabled(IDC_IMPORT_SETTINGS, true);
   menuState_->UpdateCommandEnabled(IDC_FEEDBACK, true);
   menuState_->UpdateCommandEnabled(IDC_SHOW_SYNC_SETUP, true);