Chromium Code Reviews| Index: net/base/capturing_net_log.h |
| =================================================================== |
| --- net/base/capturing_net_log.h (revision 140196) |
| +++ net/base/capturing_net_log.h (working copy) |
| @@ -26,13 +26,11 @@ |
| namespace net { |
| // CapturingNetLog is an implementation of NetLog that saves messages to a |
| -// bounded buffer. CapturingNetLogs should only be used in unit tests, never |
| -// in production code. |
| -// TODO(mmenke): Move CapturingNetLog to net_unittests project, once the CL |
|
eroman
2012/06/08 18:24:41
Oh I see, you removed the comment as part of this
mmenke
2012/06/08 18:28:11
Just forgot to copy it to the other one (Was think
|
| -// to remove the use of it in the Jingle unit tests has landed. |
| -class NET_EXPORT CapturingNetLog : public NetLog { |
| +// bounded buffer. It is intended for testing only, and is part of the |
| +// net_test_support project. |
| +class CapturingNetLog : public NetLog { |
| public: |
| - struct NET_EXPORT_PRIVATE CapturedEntry { |
| + struct CapturedEntry { |
| CapturedEntry(EventType type, |
| const base::TimeTicks& time, |
| Source source, |
| @@ -70,9 +68,7 @@ |
| enum { kUnbounded = -1 }; |
|
eroman
2012/06/08 18:24:41
Delete
mmenke
2012/06/08 18:28:11
Thanks, done.
|
| - // Creates a CapturingNetLog that logs a maximum of |max_num_entries| |
| - // messages. |
| - explicit CapturingNetLog(size_t max_num_entries); |
| + CapturingNetLog(); |
| virtual ~CapturingNetLog(); |
| // Returns the list of all entries in the log. |
| @@ -103,7 +99,6 @@ |
| // Last assigned source ID. Incremented to get the next one. |
| base::subtle::Atomic32 last_id_; |
| - size_t max_num_entries_; |
| CapturedEntryList captured_entries_; |
| NetLog::LogLevel log_level_; |
| @@ -116,10 +111,9 @@ |
| // |
| // CapturingBoundNetLog can easily be converted to a BoundNetLog using the |
| // bound() method. |
| -class NET_EXPORT_PRIVATE CapturingBoundNetLog { |
| +class CapturingBoundNetLog { |
| public: |
| - explicit CapturingBoundNetLog(size_t max_num_entries); |
| - |
| + CapturingBoundNetLog(); |
| ~CapturingBoundNetLog(); |
| // The returned BoundNetLog is only valid while |this| is alive. |