Intrinsify some ByteArray methods.

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 127 matching lines @@
     return false;
   }
   __ movq(RAX, Address(RSP, + 2 * kWordSize));
   __ movq(RBX, Address(RSP, + 1 * kWordSize));
   __ movq(FieldAddress(RAX, GrowableObjectArray::data_offset()), RBX);
   __ ret();
   return true;
 }
 
 
+bool Intrinsifier::ByteArrayBase_getLength(Assembler* assembler) {
+  __ movq(RAX, Address(RSP, + 1 * kWordSize));
+  __ movq(RAX, FieldAddress(RAX, ByteArray::length_offset()));
+  __ ret();
+  // Generate enough code to satisfy patchability constraint.
+  intptr_t offset = __ CodeSize();
+  __ nop(JumpPattern::InstructionLength() - offset);
+  return true;
+}
+
+
+// Assumes the first argument is a byte array, tests if the second
+// argument is a smi, tests if the smi is within bounds of the array
+// length, and jumps to label fall_through if any test fails.  Leaves
+// the second argument in RBX.
+void TestByteArrayIndex(Assembler* assembler, Label* fall_through) {
+  __ movq(RAX, Address(RSP, + 1 * kWordSize));  // Array.
+  __ movq(RBX, Address(RSP, + 2 * kWordSize));  // Index.
+  __ testq(RBX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, fall_through, Assembler::kNearJump);  // Non-smi index.
+  // Range check.
+  __ cmpq(RBX, FieldAddress(RAX, ByteArray::length_offset()));
+  // Runtime throws exception.
+  __ j(ABOVE_EQUAL, fall_through, Assembler::kNearJump);
+}
+
+
+bool Intrinsifier::Int8Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ SmiUntag(RBX);
+  __ movsxb(RAX, FieldAddress(RAX,
+                              RBX,
+                              TIMES_1,
+                              Int8Array::data_offset()));
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+bool Intrinsifier::Uint8Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ SmiUntag(RBX);
+  __ movzxb(RAX, FieldAddress(RAX,
+                              RBX,
+                              TIMES_1,
+                              Uint8Array::data_offset()));
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+bool Intrinsifier::Int16Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ SmiUntag(RBX);

[srdjan, 2012/06/06 23:30:00]

ditto

[cshapiro, 2012/06/06 23:43:07]

Done.

+  __ movsxw(RAX, FieldAddress(RAX,
+                              RBX,
+                              TIMES_2,
+                              Int16Array::data_offset()));
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+bool Intrinsifier::Uint16Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ SmiUntag(RBX);

[srdjan, 2012/06/06 23:30:00]

ditto

+  __ movzxw(RAX, FieldAddress(RAX,
+                              RBX,
+                              TIMES_2,
+                              Uint16Array::data_offset()));
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+bool Intrinsifier::Int32Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ SmiUntag(RBX);

[srdjan, 2012/06/06 23:30:00]

Skip untagging, use TIMES_2.

[cshapiro, 2012/06/06 23:43:07]

Done.

+  __ movsxl(RAX, FieldAddress(RAX,
+                              RBX,
+                              TIMES_4,
+                              Int32Array::data_offset()));
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+bool Intrinsifier::Uint32Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ SmiUntag(RBX);

[srdjan, 2012/06/06 23:30:00]

ditto

[cshapiro, 2012/06/06 23:43:07]

Done.

+  __ movl(RAX, FieldAddress(RAX,
+                            RBX,
+                            TIMES_4,
+                            Uint32Array::data_offset()));
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
 bool Intrinsifier::Integer_addFromInteger(Assembler* assembler) {
   return false;
 }
 
 
 bool Intrinsifier::Integer_add(Assembler* assembler) {
   return false;
 }
 
 
@@ skipping 246 matching lines @@
 
 bool Intrinsifier::String_isEmpty(Assembler* assembler) {
   return false;
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64