Adds parsing for the app_id field from an "open-with-" link

Adds parsing for the app_id field from an "open-with-" link
in Drive.  Later CLs will use app_id field to look up an associated app.

Also adjusted unit test so that it would assert less and expect more.
I expect more from my unit tests. :-)

BUG=chromium:126895
TEST=Ran updated unit test.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141680

[zel, 2012-06-06 23:29:59]

http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_parser_unittest.cc (right):

http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:140: IF_EXPECT_EQ(1U,
folder_entry->authors().size()) {
we shouldn't replace ASSERT_TRUE() here. what are we getting achieving with this
new #define?

[zel, 2012-06-06 23:32:06]

http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_parser.cc (right):

http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_parser.cc:286: if (rel.size() < 46 ||
(rel[36] != 'o' && rel[36] != 'O')) {
make 46 constant as kMinAppRelSize and get rid of (rel[36] != 'o' && rel[36] !=
'O') check

[Greg Spencer (Chromium), 2012-06-06 23:33:26]

On 2012/06/06 23:29:59, zel wrote:
>
http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
> File chrome/browser/chromeos/gdata/gdata_parser_unittest.cc (right):
> 
>
http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
> chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:140: IF_EXPECT_EQ(1U,
> folder_entry->authors().size()) {
> we shouldn't replace ASSERT_TRUE() here. what are we getting achieving with
this
> new #define?

Asserts should be for when continuing with the entire test makes no sense, or
when the setup for the test itself fails.  If we convert to EXPECT for some of
these, then other tests can run and give more information.

For instance, if a particular type of link isn't found when parsing, that
shouldn't stop us from seeing if other types are found: it gives more
information to know if it's just that one link type that's missing or all of
them (I ran into this exact case while debugging).

[Greg Spencer (Chromium), 2012-06-06 23:33:41]

On 2012/06/06 23:33:26, Greg Spencer (Chromium) wrote:
> On 2012/06/06 23:29:59, zel wrote:
> >
>
http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
> > File chrome/browser/chromeos/gdata/gdata_parser_unittest.cc (right):
> > 
> >
>
http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
> > chrome/browser/chromeos/gdata/gdata_parser_unittest.cc:140: IF_EXPECT_EQ(1U,
> > folder_entry->authors().size()) {
> > we shouldn't replace ASSERT_TRUE() here. what are we getting achieving with
> this
> > new #define?
> 
> Asserts should be for when continuing with the rest of the test makes no
sense, or
> when the setup for the test itself fails.  If we convert to EXPECT for some of
> these, then other tests can run and give more information.
> 
> For instance, if a particular type of link isn't found when parsing, that
> shouldn't stop us from seeing if other types are found: it gives more
> information to know if it's just that one link type that's missing or all of
> them (I ran into this exact case while debugging).

[Greg Spencer (Chromium), 2012-06-07 00:05:27]

http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_parser.cc (right):

http://codereview.chromium.org/10546034/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_parser.cc:286: if (rel.size() < 46 ||
(rel[36] != 'o' && rel[36] != 'O')) {
On 2012/06/06 23:32:07, zel wrote:
> make 46 constant as kMinAppRelSize and get rid of (rel[36] != 'o' && rel[36]
!=
> 'O') check

Done.  I went with kOpenWithPrefixSize instead though (because I used it below
too)

[Greg Spencer (Chromium), 2012-06-11 21:27:59]

Ping.

[zel, 2012-06-11 22:19:38]

http://codereview.chromium.org/10546034/diff/6002/chrome/test/data/chromeos/g...
File chrome/test/data/chromeos/gdata/entry.xml (right):

http://codereview.chromium.org/10546034/diff/6002/chrome/test/data/chromeos/g...
chrome/test/data/chromeos/gdata/entry.xml:1: <?xml version="1.0"
encoding="UTF-8"?><entry gd:etag="&quot;HhMOFgcNHSt7ImBr&quot;"
xmlns="http://www.w3.org/2005/Atom"
xmlns:batch="http://schemas.google.com/gdata/batch"
xmlns:docs="http://schemas.google.com/docs/2007"
xmlns:gd="http://schemas.google.com/g/2005"><id>https://xml_file_id</id><published>2010-11-07T05:03:54.719Z</published><updated>2011-04-01T18:34:08.234Z</updated><app:edited
xmlns:app="http://www.w3.org/2007/app">2012-03-21T04:35:08.213Z</app:edited><category
label="application/x-tar" scheme="http://schemas.google.com/g/2005#kind"
term="http://schemas.google.com/docs/2007#file"/><category
label="modified-by-me" scheme="http://schemas.google.com/g/2005/labels"
term="http://schemas.google.com/g/2005/labels#modified-by-me"/><title>Xml Entry
File Title.tar</title><content src="https://1_xml_file_entry_content_url/"
type="application/x-tar"/><link href="https://xml_file_entry_id_alternate_link/"
rel="alternate" type="text/html"/><link
href="https://xml_file_entry_id_resumable_edit_media_link/icon.png"
rel="http://schemas.google.com/docs/2007#icon" type="image/png"/><link
href="https://xml_file_entry_id_resumable_edit_media_link/"
rel="http://schemas.google.com/g/2005#resumable-edit-media"
type="application/atom+xml"/><link
href="https://xml_file_entry_id_alt_edit_media_link/"
rel="http://schemas.google.com/docs/2007#alt-edit-media"
type="application/atom+xml"/><link href="https://xml_file_entry_id_self_link/"
rel="self" type="application/atom+xml"/><link
href="https://xml_file_entry_id_edit_link/" rel="edit"
type="application/atom+xml"/><link
href="https://xml_file_entry_id_edit_media_link/" rel="edit-media"
type="application/x-tar"/><link href="https://xml_file_entry_open_with_link/"
rel="http://schemas.google.com/docs/2007#open-with-the_app_id"
type="application/atom+xml"/><link
href="https://xml_file_fake_entry_open_with_link/"
rel="http://schemas.google.com/docs/2007#oh-no-not-open-with-the_app_id"
type="application/atom+xml"/><author><name>entry_tester</name><email>entry_tester@testing.com</email></author><gd:resourceId>file:xml_file_resouce_id</gd:resourceId><docs:modifiedByMeDate>2012-03-21T04:35:08.207Z</docs:modifiedByMeDate><gd:lastModifiedBy><name>zelidrag</name><email>zelidrag@gmail.com</email></gd:lastModifiedBy><gd:quotaBytesUsed>26562560</gd:quotaBytesUsed><docs:writersCanInvite
value="true"/><docs:md5Checksum>e48f4d5c46a778de263e0e3f4b3d2a7d</docs:md5Checksum><docs:filename>Xml
Entry File Name.tar</docs:filename><docs:suggestedFilename>Xml Entry Suggested
File
Name.tar</docs:suggestedFilename><docs:size>26562560</docs:size><gd:feedLink
href="https://docs.google.com/feeds/xml_file_entry_id/acl"
rel="http://schemas.google.com/acl/2007#accessControlList"/><gd:feedLink
href="https://docs.google.com/feeds/xml_file_entry_id/revisions"
rel="http://schemas.google.com/docs/2007/revisions"/></entry>
why this file got changed?  your tests are expecting that .json file change
instead?

[Greg Spencer (Chromium), 2012-06-11 23:19:20]

http://codereview.chromium.org/10546034/diff/6002/chrome/test/data/chromeos/g...
File chrome/test/data/chromeos/gdata/entry.xml (right):

http://codereview.chromium.org/10546034/diff/6002/chrome/test/data/chromeos/g...
chrome/test/data/chromeos/gdata/entry.xml:1: <?xml version="1.0"
encoding="UTF-8"?><entry gd:etag="&quot;HhMOFgcNHSt7ImBr&quot;"
xmlns="http://www.w3.org/2005/Atom"
xmlns:batch="http://schemas.google.com/gdata/batch"
xmlns:docs="http://schemas.google.com/docs/2007"
xmlns:gd="http://schemas.google.com/g/2005"><id>https://xml_file_id</id><published>2010-11-07T05:03:54.719Z</published><updated>2011-04-01T18:34:08.234Z</updated><app:edited
xmlns:app="http://www.w3.org/2007/app">2012-03-21T04:35:08.213Z</app:edited><category
label="application/x-tar" scheme="http://schemas.google.com/g/2005#kind"
term="http://schemas.google.com/docs/2007#file"/><category
label="modified-by-me" scheme="http://schemas.google.com/g/2005/labels"
term="http://schemas.google.com/g/2005/labels#modified-by-me"/><title>Xml Entry
File Title.tar</title><content src="https://1_xml_file_entry_content_url/"
type="application/x-tar"/><link href="https://xml_file_entry_id_alternate_link/"
rel="alternate" type="text/html"/><link
href="https://xml_file_entry_id_resumable_edit_media_link/icon.png"
rel="http://schemas.google.com/docs/2007#icon" type="image/png"/><link
href="https://xml_file_entry_id_resumable_edit_media_link/"
rel="http://schemas.google.com/g/2005#resumable-edit-media"
type="application/atom+xml"/><link
href="https://xml_file_entry_id_alt_edit_media_link/"
rel="http://schemas.google.com/docs/2007#alt-edit-media"
type="application/atom+xml"/><link href="https://xml_file_entry_id_self_link/"
rel="self" type="application/atom+xml"/><link
href="https://xml_file_entry_id_edit_link/" rel="edit"
type="application/atom+xml"/><link
href="https://xml_file_entry_id_edit_media_link/" rel="edit-media"
type="application/x-tar"/><link href="https://xml_file_entry_open_with_link/"
rel="http://schemas.google.com/docs/2007#open-with-the_app_id"
type="application/atom+xml"/><link
href="https://xml_file_fake_entry_open_with_link/"
rel="http://schemas.google.com/docs/2007#oh-no-not-open-with-the_app_id"
type="application/atom+xml"/><author><name>entry_tester</name><email>entry_tester@testing.com</email></author><gd:resourceId>file:xml_file_resouce_id</gd:resourceId><docs:modifiedByMeDate>2012-03-21T04:35:08.207Z</docs:modifiedByMeDate><gd:lastModifiedBy><name>zelidrag</name><email>zelidrag@gmail.com</email></gd:lastModifiedBy><gd:quotaBytesUsed>26562560</gd:quotaBytesUsed><docs:writersCanInvite
value="true"/><docs:md5Checksum>e48f4d5c46a778de263e0e3f4b3d2a7d</docs:md5Checksum><docs:filename>Xml
Entry File Name.tar</docs:filename><docs:suggestedFilename>Xml Entry Suggested
File
Name.tar</docs:suggestedFilename><docs:size>26562560</docs:size><gd:feedLink
href="https://docs.google.com/feeds/xml_file_entry_id/acl"
rel="http://schemas.google.com/acl/2007#accessControlList"/><gd:feedLink
href="https://docs.google.com/feeds/xml_file_entry_id/revisions"
rel="http://schemas.google.com/docs/2007/revisions"/></entry>
On 2012/06/11 22:19:38, zel wrote:
> why this file got changed?  your tests are expecting that .json file change
> instead?

Hmm.  Yeah, actually they both needed to change, but I forget to add a JSON
test.  I added that, so PTAL.

[zel, 2012-06-12 08:41:09]

lgtm

[commit-bot: I haz the power, 2012-06-12 16:26:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10546034/5002

[commit-bot: I haz the power, 2012-06-12 17:39:24]

Change committed as 141680