[Sync] Propagate XMPP auth errors to SyncNotifierObservers

jingle/notifier/communicator/single_login_attempt_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/communicator/single_login_attempt.h"
 
 #include <cstddef>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "jingle/notifier/base/const_communicator.h"
 #include "jingle/notifier/base/fake_base_task.h"
 #include "jingle/notifier/communicator/login_settings.h"
 #include "net/base/mock_host_resolver.h"
 #include "net/url_request/url_request_test_util.h"
-#include "testing/gtest/include/gtest/gtest.h"
 #include "talk/xmllite/xmlelement.h"
 #include "talk/xmpp/constants.h"
 #include "talk/xmpp/xmppengine.h"
+#include "testing/gtest/include/gtest/gtest.h"
 
 namespace buzz {
 class XmppTaskParentInterface;
 }  // namespace buzz
 
 namespace notifier {
 
 namespace {
 
-enum DelegateState { IDLE, CONNECTED, NEED_RECONNECT, REDIRECTED };
+enum DelegateState {
+  IDLE, CONNECTED, REDIRECTED, CREDENTIALS_REJECTED, SETTINGS_EXHAUSTED
+};
 
 class FakeDelegate : public SingleLoginAttempt::Delegate {
  public:
   FakeDelegate() : state_(IDLE) {}
 
-  void OnConnect(base::WeakPtr<buzz::XmppTaskParentInterface> base_task) {
+  void OnConnect(
+      base::WeakPtr<buzz::XmppTaskParentInterface> base_task) OVERRIDE {
     state_ = CONNECTED;
     base_task_ = base_task;
   }
 
-  virtual void OnNeedReconnect() {
-    state_ = NEED_RECONNECT;
-  }
-
   virtual void OnRedirect(const ServerInformation& redirect_server) OVERRIDE {
     state_ = REDIRECTED;
     redirect_server_ = redirect_server;
   }
 
+  virtual void OnCredentialsRejected() OVERRIDE {
+    state_ = CREDENTIALS_REJECTED;
+  }
+
+  virtual void OnSettingsExhausted() OVERRIDE {
+    state_ = SETTINGS_EXHAUSTED;
+  }
+
   DelegateState state() const { return state_; }
 
   base::WeakPtr<buzz::XmppTaskParentInterface> base_task() const {
     return base_task_;
   }
 
   const ServerInformation& redirect_server() const {
     return redirect_server_;
   }
 
@@ skipping 48 matching lines @@
 
 // Fire OnConnect and make sure the base task gets passed to the
 // delegate properly.
 TEST_F(SingleLoginAttemptTest, Basic) {
   attempt_.OnConnect(fake_base_task_.AsWeakPtr());
   EXPECT_EQ(CONNECTED, fake_delegate_.state());
   EXPECT_EQ(fake_base_task_.AsWeakPtr().get(),
             fake_delegate_.base_task().get());
 }
 
-// Fire OnErrors and make sure the delegate gets the OnNeedReconnect()
-// event.
+// Fire OnErrors and make sure the delegate gets the
+// OnSettingsExhausted() event.
 TEST_F(SingleLoginAttemptTest, Error) {
   for (int i = 0; i < 2; ++i) {
     EXPECT_EQ(IDLE, fake_delegate_.state());
     attempt_.OnError(buzz::XmppEngine::ERROR_NONE, 0, NULL);
   }
-  EXPECT_EQ(NEED_RECONNECT, fake_delegate_.state());
+  EXPECT_EQ(SETTINGS_EXHAUSTED, fake_delegate_.state());
 }
 
 // Fire OnErrors but replace the last one with OnConnect, and make
 // sure the delegate still gets the OnConnect message.
 TEST_F(SingleLoginAttemptTest, ErrorThenSuccess) {
   attempt_.OnError(buzz::XmppEngine::ERROR_NONE, 0, NULL);
   attempt_.OnConnect(fake_base_task_.AsWeakPtr());
   EXPECT_EQ(CONNECTED, fake_delegate_.state());
   EXPECT_EQ(fake_base_task_.AsWeakPtr().get(),
             fake_delegate_.base_task().get());
@@ skipping 90 matching lines @@
 
 // Fire a redirect with a missing see-other-host element and make sure
 // the delegate does not get a redirect.
 TEST_F(SingleLoginAttemptTest, RedirectMissingSeeOtherHost) {
   scoped_ptr<buzz::XmlElement> redirect_error(MakeRedirectError(""));
   redirect_error->RemoveChildAfter(NULL);
   FireRedirect(redirect_error.get());
   EXPECT_EQ(IDLE, fake_delegate_.state());
 }
 
+// Fire 'Unauthorized' errors and make sure the delegate gets the
+// OnCredentialsRejected() event.
+TEST_F(SingleLoginAttemptTest, CredentialsRejected) {
+  attempt_.OnError(buzz::XmppEngine::ERROR_UNAUTHORIZED, 0, NULL);
+  EXPECT_EQ(CREDENTIALS_REJECTED, fake_delegate_.state());
+}
+
 }  // namespace
 
 }  // namespace notifier