Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: lib/unittest/core_matchers.dart

Issue 10545167: Some unit test fixes: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/unittest/unittest.dart » ('j') | lib/unittest/unittest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/core_matchers.dart
===================================================================
--- lib/unittest/core_matchers.dart (revision 8626)
+++ lib/unittest/core_matchers.dart (working copy)
@@ -141,8 +141,6 @@
* The value passed to expect() should be a reference to the function.
* Note that the function cannot take arguments; to handle this
* a wrapper will have to be created.
- * The function will be called once upon success, or twice upon failure
- * (the second time to get the failure description).
*/
Matcher throwsA(Matcher matcher) => new _Throws(matcher);
@@ -179,11 +177,11 @@
}
Description describeMismatch(item, Description mismatchDescription) {
- try {
- item();
+ if (_matcher == null) {
return mismatchDescription.add(' no exception');
- } catch (final e) {
- return mismatchDescription.add(' exception does not match ').
+ } else {
+ return mismatchDescription.
+ add(' no exception or exception does not match ').
addDescriptionOf(_matcher);
}
}
« no previous file with comments | « no previous file | lib/unittest/unittest.dart » ('j') | lib/unittest/unittest.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698