Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 10545159: Fix for 3607 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
===================================================================
--- compiler/java/com/google/dart/compiler/parser/DartParser.java (revision 8615)
+++ compiler/java/com/google/dart/compiler/parser/DartParser.java (working copy)
@@ -1367,7 +1367,19 @@
}
// Parse the parameters definitions.
- List<DartParameter> parameters = parseFormalParameterList();
+ List<DartParameter> parameters;
+ if (modifiers.isGetter() && peek(0) != Token.LPAREN) {
+ // TODO: For now the parameters are optional so that both the old and new style will be
+ // accepted, but eventually parameters should be disallowed.
+ parameters = new ArrayList<DartParameter>();
+ } else {
+ if (modifiers.isSetter()) {
+ // TODO: For now we optionally allow an equal sign before the formal parameter list, but
+ // eventually it should be required.
+ optional(Token.ASSIGN);
+ }
+ parameters = parseFormalParameterList();
+ }
if (arity != -1) {
if (parameters.size() != arity) {
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698