Removes constructor initializer in named parameter of private member

Removes constructor initializer in named parameter of private member

See spec section 6.2.2, this is a compile time error.

Committed: https://code.google.com/p/dart/source/detail?r=8536

[zundel, 2012-06-11 15:52:34]

I'm working on adding a compilet-time error to the analyzer in
http://codereview.chromium.org/10541095/

Section 6.2.2 of the spec says you can't use names starting
with '_' for named parameters, and the implication is that in constructors,
initialzing a private with a named parameter has to be done the long way.  These
three files need to be modified.  I'm thinking that most uses pass the parameter
positionally so it doesn't matter, but it could cause callers to break.

[Ivan Posva, 2012-06-12 10:43:05]

LGTM with comment.

-Ivan

http://codereview.chromium.org/10545114/diff/2001/lib/unittest/numeric_matche...
File lib/unittest/numeric_matchers.dart (right):

http://codereview.chromium.org/10545114/diff/2001/lib/unittest/numeric_matche...
lib/unittest/numeric_matchers.dart:98: [valueInDescription = true]) :
this._valueInDescription = valueInDescription;
Long line?

[zundel, 2012-06-12 10:53:00]

(note to prosperity, gram gave his approval on the other CL)

On 2012/06/12 10:43:05, Ivan Posva wrote:
> LGTM with comment.
> 
> -Ivan
> 
>
http://codereview.chromium.org/10545114/diff/2001/lib/unittest/numeric_matche...
> File lib/unittest/numeric_matchers.dart (right):
> 
>
http://codereview.chromium.org/10545114/diff/2001/lib/unittest/numeric_matche...
> lib/unittest/numeric_matchers.dart:98: [valueInDescription = true]) :
> this._valueInDescription = valueInDescription;
> Long line?

[zundel, 2012-06-12 10:53:42]

I mean posterity!

On 2012/06/12 10:53:00, zundel wrote:
> (note to prosperity, gram gave his approval on the other CL)
> 
> On 2012/06/12 10:43:05, Ivan Posva wrote:
> > LGTM with comment.
> > 
> > -Ivan
> > 
> >
>
http://codereview.chromium.org/10545114/diff/2001/lib/unittest/numeric_matche...
> > File lib/unittest/numeric_matchers.dart (right):
> > 
> >
>
http://codereview.chromium.org/10545114/diff/2001/lib/unittest/numeric_matche...
> > lib/unittest/numeric_matchers.dart:98: [valueInDescription = true]) :
> > this._valueInDescription = valueInDescription;
> > Long line?