Extensions docs server: Design changes, partial template support.

chrome/common/extensions/docs/server2/subversion_fetcher.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 SUBVERSION_URL = 'http://src.chromium.org/viewvc/chrome/'
 TRUNK_URL = SUBVERSION_URL + 'trunk/'
 BRANCH_URL = SUBVERSION_URL + 'branches/'
 
 class SubversionFetcher(object):
   """Class to fetch resources from src.chromium.org.
   """
-  def __init__(self, base_path, urlfetch):
-    self.base_path = base_path
-    self.urlfetch = urlfetch
+  def __init__(self, branch, base_path, urlfetch):
+    self._base_path = self._GetURLFromBranch(branch) + base_path
+    self._urlfetch = urlfetch

[not at google - send to devlin, 2012/06/07 04:43:57]

url_fetcher ?

[cduvall, 2012/06/08 00:39:23]

Done.

 
   def _GetURLFromBranch(self, branch):
     if branch == 'trunk':
       return TRUNK_URL + 'src/'
     return BRANCH_URL + branch + '/src/'
 
-  def FetchResource(self, branch, path):
-    url = self._GetURLFromBranch(branch) + self.base_path + path
-    result = self.urlfetch.fetch(url)
+  def FetchResource(self, path):
+    url =  self._base_path + path
+    result = self._urlfetch.fetch(url)
     return result

[not at google - send to devlin, 2012/06/07 04:43:57]

nit: inline url and result

[cduvall, 2012/06/08 00:39:23]

Done.