Extensions docs server: Design changes, partial template support.

chrome/common/extensions/docs/server2/local_fetcher.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 
 class LocalFetcher(object):
   """Class to fetch resources from local filesystem.
   """
   def __init__(self, base_path):
-    self.base_path = base_path
+    self._base_path = os.path.join(*base_path.split('/'))

[not at google - send to devlin, 2012/06/07 04:43:57]

Could you combine this and the stuff on line 24 into a separate function?

Also, I think that path.replace('/', os.sep) might be simpler.

[cduvall, 2012/06/08 00:39:23]

Done.

 
   class _Resource(object):
     def __init__(self):
       self.content = ''
       self.headers = {}
 
   def _ReadFile(self, filename):

[not at google - send to devlin, 2012/06/07 04:43:57]

Perhaps make this prepend base_path itself, rather than threading through an
instance variable into an instance method (which is redundant). You could also
do the logging here and save needing to os.path.join twice.

[cduvall, 2012/06/08 00:39:23]

Done.

     with open(filename, 'r') as f:
       return f.read()
 
-  def FetchResource(self, branch, path):
+  def FetchResource(self, path):
     real_path = os.path.join(*path.split('/'))
     result = self._Resource()
-    logging.info('Reading: ' + os.path.join(self.base_path, real_path))
-    result.content = self._ReadFile(os.path.join(self.base_path, real_path))
+    logging.info('Reading: ' + os.path.join(self._base_path, real_path))
+    result.content = self._ReadFile(os.path.join(self._base_path, real_path))

[not at google - send to devlin, 2012/06/07 04:43:57]

Just pass content through to Resource in __init__ ?

[cduvall, 2012/06/08 00:39:23]

Done.

     return result