chrome/browser/resources/extensions/extension_info.html - Issue 10544195: Show an extension info bubble when a script badge is clicked.

Side by Side Diff: chrome/browser/resources/extensions/extension_info.html

Issue 10544195: Show an extension info bubble when a script badge is clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleaner Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/extensions/extension_info.css ('K') | « chrome/browser/resources/extensions/extension_info.css ('k') | chrome/browser/resources/extensions/extension_info.js » ('j') | chrome/browser/ui/webui/extensions/extension_info_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html i18n-values="dir:textdirection;">

	3 <head>

	4 <meta charset="utf-8">

	5 <link rel="stylesheet" href="extension_info.css">
	Evan Stade 2012/06/21 18:56:22 chrome_shared.css chrome_shared.css Yoyo Zhou 2012/06/21 21:38:05 Added. It seems silly to do this and then get ugly Show quoted text On 2012/06/21 18:56:22, Evan Stade wrote: > chrome_shared.css Added. It seems silly to do this and then get ugly values for the body margin and p line-height that I then have to override. I can understand these guidelines for WebUI that fills a whole tab, but for a popup, I'm aiming more for the page info popup style. Evan Stade 2012/06/21 21:46:06 yea, but chrome_shared has more in it than just th Show quoted text On 2012/06/21 21:38:05, Yoyo Zhou wrote: > On 2012/06/21 18:56:22, Evan Stade wrote: > > chrome_shared.css > > Added. It seems silly to do this and then get ugly values for the body margin > and p line-height that I then have to override. I can understand these > guidelines for WebUI that fills a whole tab, but for a popup, I'm aiming more > for the page info popup style. yea, but chrome_shared has more in it than just those things you stated. You can ping Glen about this, but I think we do generally want the extra spacing for multi-line text. That's why it's in chrome_shared.css. I don't know why this would be different for this popup vs., e.g., chrome://extensions. Yoyo Zhou 2012/06/22 19:20:53 I talked to Glen about this, who advised me that L Show quoted text On 2012/06/21 21:46:06, Evan Stade wrote: > On 2012/06/21 21:38:05, Yoyo Zhou wrote: > > On 2012/06/21 18:56:22, Evan Stade wrote: > > > chrome_shared.css > > > > Added. It seems silly to do this and then get ugly values for the body margin > > and p line-height that I then have to override. I can understand these > > guidelines for WebUI that fills a whole tab, but for a popup, I'm aiming more > > for the page info popup style. > > yea, but chrome_shared has more in it than just those things you stated. You can > ping Glen about this, but I think we do generally want the extra spacing for > multi-line text. That's why it's in chrome_shared.css. I don't know why this > would be different for this popup vs., e.g., chrome://extensions. I talked to Glen about this, who advised me that Linux is not a good platform on which to base decisions like this. We agreed that it looks better with the extra spacing on Mac, so I'll go with that.
	6

	7 <script src="chrome://resources/js/cr.js"></script>

	8 <script src="chrome://resources/js/load_time_data.js"></script>

	9 <script src="chrome://resources/js/util.js"></script>

	10

	11 <script src="chrome://extension-info/extension_info.js"></script>

	12 </head>

	13

	14 <body>
	Evan Stade 2012/06/21 18:56:22 <body i18n-values=".style.fontFamily:fontfamily;.s <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> Yoyo Zhou 2012/06/21 21:38:05 Huh, aa asked me to remove them since they were ap Show quoted text On 2012/06/21 18:56:22, Evan Stade wrote: > <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> Huh, aa asked me to remove them since they were apparently not doing anything, but I'll defer to you on this one. Evan Stade 2012/06/21 21:46:06 they do something, but you have to call ChromeURLD Show quoted text On 2012/06/21 21:38:05, Yoyo Zhou wrote: > On 2012/06/21 18:56:22, Evan Stade wrote: > > <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> > > Huh, aa asked me to remove them since they were apparently not doing anything, > but I'll defer to you on this one. they do something, but you have to call ChromeURLDataManager::DataSource::SetFontAndTextDirection() on your dictionary.
	15

	16 <div id="extension-item">

	17 <div id="extension-details">

	18 <div id="extension-title-running"></div>

	19 <div>

	20 <span id="extension-last-updated" i18n-content="lastUpdated"></span>

	21 <span id="extension-update-time" i18n-content="installTime"></span>

	22 </div>

	23 <p id="extension-description" i18n-content="description"></p>

	24 </div>

	25 </div>

	26

	27 <script src="chrome://extension-info/strings.js"></script>

	28 <script src="chrome://resources/js/i18n_template2.js"></script>

	29 </body>

	30 </html>

OLD	NEW