Chromium Code Reviews Chromium Code Reviews
Issue 10544171:
Add OptionsUI and its handler for multiple displays. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <div id="settings" class="page" hidden> | 1 <div id="settings" class="page" hidden> |
| 2 <header> | 2 <header> |
| 3 <h1 i18n-content="settingsTitle"></h1> | 3 <h1 i18n-content="settingsTitle"></h1> |
| 4 </header> | 4 </header> |
| 5 <if expr="not pp_ifdef('chromeos')"> | 5 <if expr="not pp_ifdef('chromeos')"> |
| 6 <include src="sync_section.html"> | 6 <include src="sync_section.html"> |
| 7 </if> | 7 </if> |
| 8 <if expr="pp_ifdef('chromeos')"> | 8 <if expr="pp_ifdef('chromeos')"> |
| 9 <section> | 9 <section> |
| 10 <h3 i18n-content="sectionTitleInternet"></h3> | 10 <h3 i18n-content="sectionTitleInternet"></h3> |
| (...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 251 <if expr="not pp_ifdef('chromeos')"> | 251 <if expr="not pp_ifdef('chromeos')"> |
| 252 <input id="metricsReportingEnabled" type="checkbox"> | 252 <input id="metricsReportingEnabled" type="checkbox"> |
| 253 </if> | 253 </if> |
| 254 <span i18n-content="enableLogging"></span> | 254 <span i18n-content="enableLogging"></span> |
| 255 </label> | 255 </label> |
| 256 </div> | 256 </div> |
| 257 </if> <!-- pp_ifdef('_google_chrome') --> | 257 </if> <!-- pp_ifdef('_google_chrome') --> |
| 258 </div> | 258 </div> |
| 259 </section> | 259 </section> |
| 260 <if expr="pp_ifdef('chromeos')"> | 260 <if expr="pp_ifdef('chromeos')"> |
| 261 <!-- By default, the display section is hidden. It is only visible if | |
| 262 more than one displays are found. --> | |
|
James Hawkins
2012/06/18 15:13:49
s/displays are/display is/
Jun Mukai
2012/06/19 08:37:44
Done.
| |
| 263 <section id="display-options-section" hidden> | |
| 264 <h3 i18n-content="displayOptionsTitle"></h3> | |
| 265 <div> | |
| 266 <div> | |
|
James Hawkins
2012/06/18 15:13:49
Why are you using this extra div?
Jun Mukai
2012/06/19 08:37:44
forgot the reason... removed. thanks.
| |
| 267 <div class="settings-row"> | |
| 268 <button id="displayOptionsButton" | |
|
James Hawkins
2012/06/18 15:13:49
IDs use 'dash-form'.
Jun Mukai
2012/06/19 08:37:44
Done.
| |
| 269 i18n-content="displayOptionsButton"></button> | |
| 270 </div> | |
| 271 </div> | |
| 272 </div> | |
| 273 </section> | |
| 274 | |
| 261 <!-- By default, the bluetooth section is hidden. It is only visible if a | 275 <!-- By default, the bluetooth section is hidden. It is only visible if a |
| 262 bluetooth adapter is discovered --> | 276 bluetooth adapter is discovered --> |
| 263 <section id="bluetooth-devices" hidden> | 277 <section id="bluetooth-devices" hidden> |
| 264 <h3 i18n-content="bluetooth"></h3> | 278 <h3 i18n-content="bluetooth"></h3> |
| 265 <div id="bluetooth-options-div"> | 279 <div id="bluetooth-options-div"> |
| 266 <div class="checkbox"> | 280 <div class="checkbox"> |
| 267 <label> | 281 <label> |
| 268 <input type="checkbox" id="enable-bluetooth"> | 282 <input type="checkbox" id="enable-bluetooth"> |
| 269 <span i18n-content="enableBluetooth"> | 283 <span i18n-content="enableBluetooth"> |
| 270 </label> | 284 </label> |
| (...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 512 </section> | 526 </section> |
| 513 </if> | 527 </if> |
| 514 </div> <!-- advanced-settings-container --> | 528 </div> <!-- advanced-settings-container --> |
| 515 </div> <!-- advanced-settings --> | 529 </div> <!-- advanced-settings --> |
| 516 <footer> | 530 <footer> |
| 517 <button id="advanced-settings-expander" class="link-button" | 531 <button id="advanced-settings-expander" class="link-button" |
| 518 i18n-content="showAdvancedSettings"> | 532 i18n-content="showAdvancedSettings"> |
| 519 </button> | 533 </button> |
| 520 </footer> | 534 </footer> |
| 521 </div> | 535 </div> |
| OLD | NEW |
