Some unit test fixes

lib/unittest/expect.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**

[eub, 2012/06/15 22:30:43]

Document that "matcher" may be a value to match for equality, assuming that is a
documented part of the interface.

  * This is the main assertion function. It asserts that [actual]
  * matches the [matcher]. [reason] is optional and is typically
  * not supplied, as a reason can be generated from the matcher.
  * If [reason] is included it is appended to the reason generated
  * by the matcher.
  *
  * If the assertion fails, then the default behavior is to throw an
  * [ExpectException], but this behavior can be changed by calling
  * [configureExpectHandler] and providing an alternative handler that
  * implements the [IFailureHandler] interface.
  *
  * [expect] allows an alternative call format, providing a Boolean
- * predicate as the first argument and an optional reason as the
+ * predicate as the first argument and an optional reason as a named
  * second argument. This supports brevity at the expense of detailed
  * error messages. For example, these are equivalent, but the first
  * form will give a detailed error message, while the second form will
  * just give a generic assertion failed message:
  *
  *     expect(foo, isLessThanOrEqual(bar));
  *     expect(foo <= bar);
  *
+ * A better way of doing the second form is:
+ *
+ *     expect(foo <= bar, reason: "foo not less than bar");

[eub, 2012/06/15 22:30:43]

Utter nitpick: "foo not less than or equal to bar" :-P

[gram, 2012/06/15 22:40:42]

Done.

+ *
  * expect() is a 3rd generation assertion mechanism, drawing
  * inspiration from [Hamcrest] and Ladislav Thon's [dart-matchers]
  * library.
  *
  * See [Hamcrest] http://en.wikipedia.org/wiki/Hamcrest
  *     [Hamcrest] http://http://code.google.com/p/hamcrest/
  *     [dart-matchers] https://github.com/Ladicek/dart-matchers
  */
-void expect(actual, [matcherOrReason = null, String reason = '']) {
-  if (matcherOrReason is Matcher) {
+void expect(actual, [matcher = null, String reason = '']) {

[eub, 2012/06/15 22:30:43]

How do you like null instead of ''?

[gram, 2012/06/15 22:40:42]

Done.

[gram, 2012/06/15 22:40:42]

Done.

+  if (matcher == null) {
+    // Treat this as an assert(predicate, reason).

[eub, 2012/06/15 22:30:43]

[reason]

[gram, 2012/06/15 22:40:42]

Done.

+    if (!actual) {
+      if (reason == '') {
+        reason = 'Assertion failed';
+      }
+      // Make sure we have a failure handler configured.
+      configureExpectHandler(_assertFailureHandler);
+      _assertFailureHandler.fail(reason);
+    }
+  } else {
+    // Treat this as an expect(value, matcher, [reason]).
+    if (matcher is! Matcher) {

[eub, 2012/06/15 22:30:43]

This is a duplicate "is" check w/ the one in wrapMatcher.

[gram, 2012/06/15 22:40:42]

Done.

+      matcher = wrapMatcher(matcher);
+    }
     var doesMatch;
     try {
-      doesMatch = matcherOrReason.matches(actual);
+      doesMatch = matcher.matches(actual);
     } catch (var e, var trace) {
       doesMatch = false;
       if (reason == '') {
         reason = '${(e is String) ? e : e.toString()} at $trace';

[eub, 2012/06/15 22:30:43]

It would be nice if String had a no-op toString, eh.

[gram, 2012/06/15 22:40:42]

:-)

       }
     }
     if (!doesMatch) {
       // Make sure we have a failure handler configured.
       configureExpectHandler(_assertFailureHandler);
-      _assertFailureHandler.failMatch(actual, matcherOrReason, reason);
-    }
-  } else {
-    if (!actual) {
-      reason = (matcherOrReason == null) ? 'Assertion failed' : matcherOrReason;
-      // Make sure we have a failure handler configured.
-      configureExpectHandler(_assertFailureHandler);
-      _assertFailureHandler.fail(reason);
+      _assertFailureHandler.failMatch(actual, matcher, reason);
     }
   }
 }
 
 /**
  * Takes an argument and returns an equivalent matcher.
  * If the argument is already a matcher this does nothing, else it
  * generates an equals matcher for the argument.
  */
 Matcher wrapMatcher(x) => ((x is Matcher) ? x : equals(x));
@@ skipping 49 matching lines @@
  * formatter is returned; this allows custom expect handlers to easily
  * get a reference to the default formatter.
  */
 ErrorFormatter configureExpectFormatter([ErrorFormatter formatter = null]) {
   if (formatter == null) {
     formatter = _defaultErrorFormatter;
   }
   return _assertErrorFormatter = formatter;
 }