runtime/bin/file_impl.dart - Issue 10544110: Fix file buffering code that uses RemoveRange on a fixed-length Uint8 array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_impl.dart

Issue 10544110: Fix file buffering code that uses RemoveRange on a fixed-length Uint8 array. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Switch to getRange. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_impl.dart

diff --git a/runtime/bin/file_impl.dart b/runtime/bin/file_impl.dart

index bc83f38cb885d594b20f1d82d7d68257e00da57f..5671f358949e1d2fd3990bbb461f8ab6f8559d8f 100644

--- a/runtime/bin/file_impl.dart

+++ b/runtime/bin/file_impl.dart

@@ -72,7 +72,7 @@ class _FileInputStream extends _BaseDataInputStream implements InputStream {

future.then((read) {

_filePosition += read;

if (read != _data.length) {

- _data.removeRange(read, _data.length - read);

+ _data = _data.getRange(0, read);

}

_position = 0;

« no previous file with comments | « no previous file | no next file » | no next file with comments »