Fix file buffering code that uses RemoveRange on a fixed-length Uint8 array.

runtime/bin/file_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _FileInputStream extends _BaseDataInputStream implements InputStream {
   _FileInputStream(String name)
       : _data = [],
         _position = 0,
         _filePosition = 0 {
     var file = new File(name);
@@ skipping 54 matching lines @@
       _closeFile();
       return;
     }
     if (_data.length != size) {
       _data = new Uint8List(size);
     }
     var future = _openedFile.readList(_data, 0, _data.length);
     future.then((read) {
       _filePosition += read;
       if (read != _data.length) {
-        _data.removeRange(read, _data.length - read);
+        var oldData = _data;

[Anders Johnsen, 2012/06/12 13:42:33]

What about
 _data = _data.getRange(0, read);

[Bill Hesse, 2012/06/12 13:47:45]

I don't know if that would be a Uint8List.  Since a Uint8List is a different
type of thing than a List, I
don't want to return things of different types.

[Anders Johnsen, 2012/06/12 13:51:24]

.getRange() is a object of same type (see runtime/lib/byte_array.dart), using a
native call to copy into the new list. It should be fairly safe to use here. In
the end, the result will be the same, so I'll leave it up to you.

+        _data = new Uint8List(read);
+        _data.fillRange(0, read, oldData, 0);
       }
       _position = 0;
 
       if (_fileLength == _filePosition) {
         _closeFile();
       }
       _checkScheduleCallbacks();
     });
   }
 
@@ skipping 1055 matching lines @@
           new FileIOException("File closed '$_name'"));
     });
     return completer.future;
   }
 
   final String _name;
   int _id;
 
   SendPort _fileService;
 }