ui/base/keycodes/OWNERS - Issue 10544106: Move usb_keycode_map.h into ui/base/keycodes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/keycodes/OWNERS

Issue 10544106: Move usb_keycode_map.h into ui/base/keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update DEPS comment (again) Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 garykac@chromium.org
	tfarina 2012/06/12 20:27:51 is this really necessary? what about the people wh is this really necessary? what about the people who wrote keyboard_code? I think ui/OWNERS is enough for this code. Wez* 2012/06/12 20:33:06 Yes, there's already a bunch of code in ui/base/ke Show quoted text On 2012/06/12 20:27:51, tfarina wrote: > is this really necessary? what about the people who wrote keyboard_code? I > think ui/OWNERS is enough for this code. Yes, there's already a bunch of code in ui/base/keycodes (mainly for testing, I think?), which I don't think Gary and I should "own". ;) garykac* 2012/06/12 20:41:37 We will need to update the table periodically as w Show quoted text On 2012/06/12 20:27:51, tfarina wrote: > is this really necessary? what about the people who wrote keyboard_code? I > think ui/OWNERS is enough for this code. We will need to update the table periodically as we add support for new key mappings. We shouldn't be OWNERS at a higher level, and don't need to bother ui/OWNERS for simple changes. There is no "set noparent" here, so the situation for the people who wrote keyboard_code is unchanged. The creator seems to be ben@, who already has OWNERship. Would it be better to add ben@ explicitly here with a comment stating that he should review changes to keyboard_code and gary/wez are for changes to usb_keycode_map.h ?
	2 wez@chromium.org

OLD	NEW