Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: ppapi/proxy/ppb_file_ref_proxy.h

Issue 10544089: Implement the file chooser as a new resource "host" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppb_file_ref_proxy.h
diff --git a/ppapi/proxy/ppb_file_ref_proxy.h b/ppapi/proxy/ppb_file_ref_proxy.h
index 64febfa1f20821d8335877ba846e754f0a2bf1d6..e4a412e9674f24dbd1a017c65e8838dfb9594133 100644
--- a/ppapi/proxy/ppb_file_ref_proxy.h
+++ b/ppapi/proxy/ppb_file_ref_proxy.h
@@ -12,6 +12,7 @@
#include "ppapi/c/pp_resource.h"
#include "ppapi/c/pp_time.h"
#include "ppapi/proxy/interface_proxy.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
#include "ppapi/proxy/proxy_completion_callback_factory.h"
#include "ppapi/utility/completion_callback_factory.h"
@@ -24,7 +25,8 @@ namespace proxy {
class SerializedVarReturnValue;
-class PPB_FileRef_Proxy : public InterfaceProxy {
+class PPAPI_PROXY_EXPORT PPB_FileRef_Proxy
+ : public NON_EXPORTED_BASE(InterfaceProxy) {
public:
explicit PPB_FileRef_Proxy(Dispatcher* dispatcher);
virtual ~PPB_FileRef_Proxy();
@@ -41,13 +43,10 @@ class PPB_FileRef_Proxy : public InterfaceProxy {
// "create info" for reconstitution in the plugin. This struct contains all
// the necessary information about the file ref.
//
- // This function is not static because it needs access to the particular
- // dispatcher and host interface.
- //
// Various PPAPI functions return file refs from various interfaces, so this
// function is public so anybody can send a file ref.
- void SerializeFileRef(PP_Resource file_ref,
- PPB_FileRef_CreateInfo* result);
+ static void SerializeFileRef(PP_Resource file_ref,
+ PPB_FileRef_CreateInfo* result);
// Creates a plugin resource from the given CreateInfo sent from the host.
// The value will be the result of calling SerializeFileRef on the host.

Powered by Google App Engine
This is Rietveld 408576698