Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: content/renderer/pepper/content_renderer_pepper_host_factory.cc

Issue 10544089: Implement the file chooser as a new resource "host" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/content_renderer_pepper_host_factory.cc
diff --git a/content/renderer/pepper/content_renderer_pepper_host_factory.cc b/content/renderer/pepper/content_renderer_pepper_host_factory.cc
index de7cf7577f532fd7c1453a0ddcd6bf1cb9643bcb..ec7e7ca12f1f6d8018675a6877d002d6edfeaef7 100644
--- a/content/renderer/pepper/content_renderer_pepper_host_factory.cc
+++ b/content/renderer/pepper/content_renderer_pepper_host_factory.cc
@@ -4,6 +4,8 @@
#include "content/renderer/pepper/content_renderer_pepper_host_factory.h"
+#include "content/renderer/pepper/pepper_instance_state_accessor.h"
+#include "content/renderer/pepper/pepper_file_chooser_host.h"
#include "ppapi/host/resource_host.h"
#include "ppapi/proxy/ppapi_messages.h"
@@ -12,8 +14,12 @@ using ppapi::host::ResourceHost;
namespace content {
ContentRendererPepperHostFactory::ContentRendererPepperHostFactory(
- RenderViewImpl* render_view)
- : render_view_(render_view) {
+ RenderViewImpl* render_view,
+ const ppapi::PpapiPermissions& permissions,
+ PepperInstanceStateAccessor* state)
+ : render_view_(render_view),
+ permissions_(permissions),
+ instance_state_(state) {
}
ContentRendererPepperHostFactory::~ContentRendererPepperHostFactory() {
@@ -24,7 +30,21 @@ scoped_ptr<ResourceHost> ContentRendererPepperHostFactory::CreateResourceHost(
const ppapi::proxy::ResourceMessageCallParams& params,
PP_Instance instance,
const IPC::Message& message) {
- // TODO(brettw) host creation goes here.
+ // Make sure the plugin is giving us a valid instance for this resource.
+ if (!instance_state_->IsValidInstance(instance))
+ return scoped_ptr<ResourceHost>();
+
+ // Resources for dev interfaces.
+ // TODO(brettw) when we support any public or private interfaces, put them in
+ // a separate switch above.
+ if (permissions_.HasPermission(ppapi::PERMISSION_DEV)) {
+ switch (message.type()) {
+ case PpapiHostMsg_FileChooser_Create::ID:
+ return scoped_ptr<ResourceHost>(new PepperFileChooserHost(
+ host, instance, params.pp_resource(), render_view_,
+ instance_state_));
+ }
+ }
return scoped_ptr<ResourceHost>();
}

Powered by Google App Engine
This is Rietveld 408576698